[PM-24051] MasterPasswordUnlockData model with response mapping and adds it to identity success response model #376
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
+ Coverage 76.41% 76.53% +0.12%
==========================================
Files 265 267 +2
Lines 24433 24651 +218
==========================================
+ Hits 18670 18867 +197
- Misses 5763 5784 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mzieniukbw
requested review from
a team and
quexten
and removed request for
a team
There was a problem hiding this comment.
Some initial comments, some of these are required, some are idiomatic (but probably required since the quality bar for SDK seems to be set much higher).
I'd like a review from someone with more rust experience such as @Hinton or @dani-garcia too. I believe specifically the request parsing is something that has not existed in the SDK so far, and there may be a better way to do this that we're unaware of.
crates/bitwarden-wasm-internal/src/key_management/master_password.rs
Outdated
Show resolved
Hide resolved
…ption-options-to-identity-sync-response
…ption-options-to-identity-sync-response
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-24051
📔 Objective
Adds
MasterPasswordUnlockDatamodel withMasterPasswordUnlockResponseModelmapping. This wiAdds
UserDecryptionOptionsResponseModelinto the identity success token response. This model includes the master password unlock field.The
/syncresponse model is autogenerated by OpenApi and already includes user decryption option and the master password unlock fields.Includes Uniffi and WASM bindings for
MasterPasswordUnlock.In further PR's we plan to use the
MasterPasswordUnlockinInitUserCryptoMethodenum - this is still in discussion.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes