Skip to content

Commit ab632bb

Browse files
authored
BRE-1040 Dockerfile shared ownership (#1301)
## ๐ŸŽŸ๏ธ Tracking [BRE-1040](https://bitwarden.atlassian.net/browse/BRE-1040) ## ๐Ÿ“” Objective Include AppSec team and BRE dept for repository-level ownership of Dockerfile, and Dockerfile related, files. ## โฐ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## ๐Ÿฆฎ Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - ๐Ÿ‘ (`:+1:`) or similar for great changes - ๐Ÿ“ (`:memo:`) or โ„น๏ธ (`:information_source:`) for notes or general info - โ“ (`:question:`) for questions - ๐Ÿค” (`:thinking:`) or ๐Ÿ’ญ (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - ๐ŸŽจ (`:art:`) for suggestions / improvements - โŒ (`:x:`) or โš ๏ธ (`:warning:`) for more significant problems or concerns needing attention - ๐ŸŒฑ (`:seedling:`) or โ™ป๏ธ (`:recycle:`) for future improvements or indications of technical debt - โ› (`:pick:`) for minor or nitpick changes [BRE-1040]: https://bitwarden.atlassian.net/browse/BRE-1040?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent e883c92 commit ab632bb

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

โ€Ž.github/CODEOWNERSโ€Ž

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ crates/bws/scripts/install.ps1
1919
crates/bws/scripts/install.sh
2020

2121
## Docker files have shared ownership ##
22-
**/Dockerfile
23-
**/*.Dockerfile
24-
**/.dockerignore
25-
**/entrypoint.sh
22+
**/Dockerfile @bitwarden/team-appsec @bitwarden/dept-bre
23+
**/*.Dockerfile @bitwarden/team-appsec @bitwarden/dept-bre
24+
**/.dockerignore @bitwarden/team-appsec @bitwarden/dept-bre
25+
**/entrypoint.sh @bitwarden/team-appsec @bitwarden/dept-bre

0 commit comments

Comments
ย (0)