[PM-28727] Upgrade to .NET 10 #5704
test-database.yml
on: pull_request
Run tests
6m 40s
Run validation
1m 54s
Validate new migration naming and order
26s
Annotations
25 warnings
|
Run validation:
src/Core/Utilities/CoreHelpers.cs#L122
The behavior of 'string.ToUpper()' could vary based on the current user's locale settings. Replace this call in 'CoreHelpers.CleanCertificateThumbprint(string)' with a call to 'string.ToUpper(CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
|
|
Run validation:
src/Core/Utilities/EnumerationProtectionHelpers.cs#L30
The behavior of 'long.Parse(string, NumberStyles)' could vary based on the current user's locale settings. Replace this call in 'EnumerationProtectionHelpers.GetIndexForInputHash(byte[], string, int)' with a call to 'long.Parse(string, NumberStyles, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run validation:
src/Core/Utilities/EmailValidation.cs#L57
The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'EmailValidation.GetDomain(string)' with a call to 'string.ToLower(CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
|
|
Run validation:
src/Core/Utilities/HostBuilderExtensions.cs#L14
The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'IHostBuilder.ConfigureCustomAppConfiguration(string[])' with a call to 'string.ToLower(CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
|
|
Run validation:
src/Core/Utilities/EncryptedStringLengthAttribute.cs#L13
The behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings. Replace this call in 'EncryptedStringLengthAttribute.FormatErrorMessage(string)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run validation:
src/Core/Utilities/JsonHelpers.cs#L127
The behavior of 'long.ToString()' could vary based on the current user's locale settings. Replace this call in 'MsEpochConverter.Write(Utf8JsonWriter, DateTime?, JsonSerializerOptions)' with a call to 'long.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run validation:
src/Core/AdminConsole/Models/Mail/DeviceApprovalRequestedViewModel.cs#L13
The behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings. Replace this call in 'DeviceApprovalRequestedViewModel.Url.get' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run validation:
src/Core/AdminConsole/OrganizationFeatures/Policies/PolicyValidators/FreeFamiliesForEnterprisePolicyValidator.cs#L45
The behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'FreeFamiliesForEnterprisePolicyValidator.NotifiesUserWithApplicablePoliciesAsync(PolicyUpdate)' with a call to 'DateTime.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run validation:
src/Core/Billing/Pricing/Organizations/Purchasable.cs#L30
The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'PurchasableJsonConverter._typePropertyName' with a call to 'string.ToLower(CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
|
|
Run validation:
src/Core/Billing/Pricing/Organizations/Purchasable.cs#L79
The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'FreeOrScalableJsonConverter._typePropertyName' with a call to 'string.ToLower(CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
|
|
Run tests
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea, dorny/test-reporter@b082adf0eced0765477756c2a610396589b8c637. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Run tests:
test/Infrastructure.IntegrationTest/AdminConsole/Repositories/OrganizationRepositoryTests.cs#L262
The behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'OrganizationRepositoryTests.GetOrganizationsForSubscriptionSyncAsync_GivenOrganizationHasChangedSeatCount_WhenGettingOrgsToUpdate_ThenReturnsOrgSubscriptionUpdate(IOrganizationRepository)' with a call to 'DateTime.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run tests:
test/Infrastructure.IntegrationTest/AdminConsole/Repositories/OrganizationRepositoryTests.cs#L262
The behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'OrganizationRepositoryTests.GetOrganizationsForSubscriptionSyncAsync_GivenOrganizationHasChangedSeatCount_WhenGettingOrgsToUpdate_ThenReturnsOrgSubscriptionUpdate(IOrganizationRepository)' with a call to 'DateTime.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run tests:
test/Infrastructure.IntegrationTest/AdminConsole/Repositories/OrganizationRepositoryTests.cs#L239
The behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'OrganizationRepositoryTests.IncrementSeatCountAsync_GivenOrganizationHasChangedSeatCountBeforeAndRecordExists_WhenUpdatingOrgSeats_ThenSubscriptionUpdateIsSaved(IOrganizationRepository)' with a call to 'DateTime.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run tests:
test/Infrastructure.IntegrationTest/AdminConsole/Repositories/OrganizationRepositoryTests.cs#L239
The behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'OrganizationRepositoryTests.IncrementSeatCountAsync_GivenOrganizationHasChangedSeatCountBeforeAndRecordExists_WhenUpdatingOrgSeats_ThenSubscriptionUpdateIsSaved(IOrganizationRepository)' with a call to 'DateTime.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run tests:
test/Infrastructure.IntegrationTest/AdminConsole/Repositories/OrganizationRepositoryTests.cs#L214
The behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'OrganizationRepositoryTests.IncrementSeatCountAsync_GivenOrganizationHasNotChangedSeatCountBefore_WhenUpdatingOrgSeats_ThenSubscriptionUpdateIsSaved(IOrganizationRepository)' with a call to 'DateTime.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run tests:
test/Infrastructure.IntegrationTest/AdminConsole/Repositories/OrganizationRepositoryTests.cs#L214
The behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'OrganizationRepositoryTests.IncrementSeatCountAsync_GivenOrganizationHasNotChangedSeatCountBefore_WhenUpdatingOrgSeats_ThenSubscriptionUpdateIsSaved(IOrganizationRepository)' with a call to 'DateTime.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run tests:
src/Infrastructure.Dapper/Dirt/Repositories/EventRepository.cs#L184
The behavior of 'long.ToString()' could vary based on the current user's locale settings. Replace this call in 'EventRepository.GetManyAsync(string, IDictionary<string, object>, DateTime, DateTime, PageOptions)' with a call to 'long.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run tests:
src/Infrastructure.Dapper/NotificationCenter/Repositories/NotificationRepository.cs#L56
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'NotificationRepository.GetByUserIdAndStatusAsync(Guid, ClientType, NotificationStatusFilter, PageOptions)' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run tests:
util/Migrator/DbUpLogger.cs#L43
The behavior of 'string.Format(string, params object[])' could vary based on the current user's locale settings. Replace this call in 'DbUpLogger.LogError(Exception, string, params object[])' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run tests:
util/Migrator/DbUpLogger.cs#L38
The behavior of 'string.Format(string, params object[])' could vary based on the current user's locale settings. Replace this call in 'DbUpLogger.LogError(string, params object[])' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run tests:
util/Migrator/DbUpLogger.cs#L33
The behavior of 'string.Format(string, params object[])' could vary based on the current user's locale settings. Replace this call in 'DbUpLogger.LogWarning(string, params object[])' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run tests:
util/Migrator/DbUpLogger.cs#L28
The behavior of 'string.Format(string, params object[])' could vary based on the current user's locale settings. Replace this call in 'DbUpLogger.LogInformation(string, params object[])' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run tests:
util/Migrator/DbUpLogger.cs#L23
The behavior of 'string.Format(string, params object[])' could vary based on the current user's locale settings. Replace this call in 'DbUpLogger.LogDebug(string, params object[])' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Run tests:
util/Migrator/DbUpLogger.cs#L18
The behavior of 'string.Format(string, params object[])' could vary based on the current user's locale settings. Replace this call in 'DbUpLogger.LogTrace(string, params object[])' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
report.xml
|
1.22 KB |
sha256:0e2c0113288bbb449d10b2292647223457679459f05a96502a07f98322462c39
|
|
|
sql.dacpac
|
160 KB |
sha256:e0170eec4d807c5b728801b943f30b8e7b986cbe8f216bc0d9d4ea6096493775
|
|