Resolve platform warnings (#5798)

* Installation Repository tests

* Formatting

* Remove extra LastActivityDate property

* Remove exclusion

Author: justindbaur

src/Core/Core.csproj

@@ -75,4 +75,8 @@
     <Folder Include="Resources\" />
     <Folder Include="Properties\" />
   </ItemGroup>
+
+  <ItemGroup>
+    <InternalsVisibleTo Include="Infrastructure.IntegrationTest" />
+  </ItemGroup>
 </Project>

src/Infrastructure.EntityFramework/Infrastructure.EntityFramework.csproj

@@ -1,10 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-    <PropertyGroup>
-      <!-- Temp exclusions until warnings are fixed -->
-      <WarningsNotAsErrors>$(WarningsNotAsErrors);CS0108</WarningsNotAsErrors>
-    </PropertyGroup>
-
     <ItemGroup>
       <PackageReference Include="AutoMapper.Extensions.Microsoft.DependencyInjection" Version="12.0.1" />
       <PackageReference Include="linq2db" Version="5.4.1" />

src/Infrastructure.EntityFramework/Platform/Installations/Models/Installation.cs

@@ -3,22 +3,12 @@
 
 namespace Bit.Infrastructure.EntityFramework.Platform;
 
-public class Installation : C.Installation
-{
-    // Shadow property - to be introduced by https://bitwarden.atlassian.net/browse/PM-11129
-    // This isn't a value or entity used by self hosted servers, but it's
-    // being added for synchronicity between database provider options.
-    public DateTime? LastActivityDate { get; set; }
-}
+public class Installation : C.Installation;
 
 public class InstallationMapperProfile : Profile
 {
     public InstallationMapperProfile()
     {
-        CreateMap<C.Installation, Installation>()
-            // Shadow property - to be introduced by https://bitwarden.atlassian.net/browse/PM-11129
-            .ForMember(i => i.LastActivityDate, opt => opt.Ignore())
-            .ReverseMap();
         CreateMap<C.Installation, Installation>().ReverseMap();
     }
 }

test/Infrastructure.IntegrationTest/Platform/Installations/InstallationRepositoryTests.cs

@@ -0,0 +1,46 @@
+using Bit.Core.Platform.Installations;
+using Bit.Infrastructure.IntegrationTest.Comparers;
+using Xunit;
+
+namespace Bit.Infrastructure.IntegrationTest.Platform.Installations;
+
+public class InstallationRepositoryTests
+{
+    [DatabaseTheory, DatabaseData]
+    public async Task GetByIdAsync_Works(IInstallationRepository installationRepository)
+    {
+        var installation = await installationRepository.CreateAsync(new Installation
+        {
+            Email = "test@email.com",
+            Key = "installation_key",
+            Enabled = true,
+        });
+
+        var retrievedInstallation = await installationRepository.GetByIdAsync(installation.Id);
+
+        Assert.NotNull(retrievedInstallation);
+        Assert.Equal("installation_key", retrievedInstallation.Key);
+    }
+
+    [DatabaseTheory, DatabaseData]
+    public async Task UpdateAsync_Works(IInstallationRepository installationRepository)
+    {
+        var installation = await installationRepository.CreateAsync(new Installation
+        {
+            Email = "test@email.com",
+            Key = "installation_key",
+            Enabled = true,
+        });
+
+        var now = DateTime.UtcNow;
+
+        installation.LastActivityDate = now;
+
+        await installationRepository.ReplaceAsync(installation);
+
+        var retrievedInstallation = await installationRepository.GetByIdAsync(installation.Id);
+
+        Assert.NotNull(retrievedInstallation.LastActivityDate);
+        Assert.Equal(now, retrievedInstallation.LastActivityDate.Value, LaxDateTimeComparer.Default);
+    }
+}