Skip to content

Commit 88036ea

Browse files
committed
local review feedback
1 parent 9d86aff commit 88036ea

File tree

4 files changed

+4
-55
lines changed

4 files changed

+4
-55
lines changed

src/Infrastructure.Dapper/Repositories/CollectionRepository.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -427,11 +427,11 @@ public async Task CreateDefaultCollectionsBulkAsync(Guid organizationId, IEnumer
427427
await BulkResourceCreationService.CreateCollectionsAsync(connection, transaction, collections);
428428
await BulkResourceCreationService.CreateCollectionsUsersAsync(connection, transaction, collectionUsers);
429429

430-
transaction.Commit();
430+
await transaction.CommitAsync();
431431
}
432432
catch
433433
{
434-
transaction.Rollback();
434+
await transaction.RollbackAsync();
435435
throw;
436436
}
437437
}

src/Infrastructure.Dapper/Repositories/DatabaseExceptionHelpers.cs

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/Infrastructure.EntityFramework/Repositories/DatabaseExceptionHelpers.cs

Lines changed: 0 additions & 34 deletions
This file was deleted.

test/Infrastructure.IntegrationTest/AdminConsole/Repositories/CollectionRepository/CreateDefaultCollectionsTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ await CreateDefaultCollectionsSharedTests.CreatesDefaultCollections_Success(
2121
}
2222

2323
[Theory, DatabaseData]
24-
public async Task CreateDefaultCollectionsBulkAsync_CreatesForNewUsersOnly_AndIgnoresExistingUsers(
24+
public async Task CreateDefaultCollectionsAsync_CreatesForNewUsersOnly_AndIgnoresExistingUsers(
2525
IOrganizationRepository organizationRepository,
2626
IUserRepository userRepository,
2727
IOrganizationUserRepository organizationUserRepository,
2828
ICollectionRepository collectionRepository)
2929
{
3030
await CreateDefaultCollectionsSharedTests.CreatesForNewUsersOnly_AndIgnoresExistingUsers(
31-
collectionRepository.CreateDefaultCollectionsBulkAsync,
31+
collectionRepository.CreateDefaultCollectionsAsync,
3232
organizationRepository,
3333
userRepository,
3434
organizationUserRepository,

0 commit comments

Comments
 (0)