Merge pull request #5 from MattLavalleeMA/fix/empty-versions

bjorkstromm · web-flow · commit f7cdd1c0dcdb · 2019-02-19T17:20:48.000+02:00
Ignore unversioned references
diff --git a/src/Depends.Core/DependencyAnalyzer.cs b/src/Depends.Core/DependencyAnalyzer.cs
@@ -1,4 +1,4 @@
-﻿using System;
+using System;
 using System.Collections.Generic;
 using System.Collections.Concurrent;
 using System.IO;
@@ -259,7 +259,9 @@ public DependencyGraph Analyze(string projectPath, string framework = null)
                 }
             }
 
+            // Ignore unversioned references like implicit SDK packages
             builder.WithEdges(analyzerResult.GetItems("PackageReference")
+                .Where(x => x.Metadata.ContainsKey("Version"))
                 .Select(x => new Edge(projectNode, libraryNodes[x.ItemSpec], x.Metadata["Version"])));
 
             var references = analyzerResult.References//GetItems("Reference")

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-using System;`
	`1`	`+using System;`
`2`	`2`	`using System.Collections.Generic;`
`3`	`3`	`using System.Collections.Concurrent;`
`4`	`4`	`using System.IO;`
`@@ -259,7 +259,9 @@ public DependencyGraph Analyze(string projectPath, string framework = null)`
`259`	`259`	`}`
`260`	`260`	`}`
`261`	`261`
	`262`	`+ // Ignore unversioned references like implicit SDK packages`
`262`	`263`	`builder.WithEdges(analyzerResult.GetItems("PackageReference")`
	`264`	`+ .Where(x => x.Metadata.ContainsKey("Version"))`
`263`	`265`	`.Select(x => new Edge(projectNode, libraryNodes[x.ItemSpec], x.Metadata["Version"])));`
`264`	`266`
`265`	`267`	`var references = analyzerResult.References//GetItems("Reference")`