Fixups;

Author: bjornbytes

src/modules/audio/audio.c

@@ -100,7 +100,6 @@ static struct {
   float orientation[4];
   float absorption[3];
   float reverb;
-  float spatialization;
 #ifdef LOVR_USE_PHONON
   IPLContext phonon;
   IPLAudioSettings audioSettings;
@@ -1213,9 +1212,9 @@ static bool phonon_mix_source(Source* source, float* _src, float* dst, float* _t
   }
 
   // Direct effects, applied in-place
-  if (false) { // TODO if has any direct effect
-    IPLDirectEffectParams* params = &source->outputs[index].direct;
-    tail |= !iplDirectEffectApply(source->directEffect, params, &src, &src);
+  IPLDirectEffectParams* directParams = &source->outputs[index].direct;
+  if (directParams.flags) {
+    tail |= !iplDirectEffectApply(source->directEffect, directParams, &src, &src);
   }
 
   // Spatialization (either binaural, panning, or upmix)

src/modules/audio/audio.h

@@ -112,8 +112,6 @@ float lovrSourceGetPitch(Source* source);
 bool lovrSourceSetPitch(Source* source, float pitch);
 float lovrSourceGetVolume(Source* source, VolumeUnit units);
 void lovrSourceSetVolume(Source* source, float volume, VolumeUnit units);
-void lovrSourceGetReverb(Source* source, float* reverb, ReverbMode* mode);
-void lovrSourceSetReverb(Source* source, float volume, ReverbMode mode);
 void lovrSourceSeek(Source* source, double time, TimeUnit units);
 double lovrSourceTell(Source* source, TimeUnit units);
 double lovrSourceGetDuration(Source* source, TimeUnit units);
@@ -130,6 +128,8 @@ void lovrSourceGetFalloff(Source* source, float* innerDistance, float* outerDist
 void lovrSourceSetFalloff(Source* source, float innerDistance, float outerDistance, float outerVolume);
 void lovrSourceGetOcclusion(Source* source, uint32_t* occlusionRays, uint32_t* transmissionRays);
 void lovrSourceSetOcclusion(Source* source, uint32_t occlusionRays, uint32_t transmissionRays);
+void lovrSourceGetReverb(Source* source, float* reverb, ReverbMode* mode);
+void lovrSourceSetReverb(Source* source, float volume, ReverbMode mode);
 float lovrSourceGetSpatialization(Source* source);
 void lovrSourceSetSpatialization(Source* source, float spatialization);