Added AV1561:MaxConstructorParameterCount configuration setting

Fixes #113

Author: Bart Koelman

docs/Configuration.md

@@ -7,6 +7,7 @@ The behavior of rules can be customized by adding a file named `CSharpGuidelines
 <cSharpGuidelinesAnalyzerSettings>
   <setting rule="AV1500" name="MaxStatementCount" value="12" />
   <setting rule="AV1561" name="MaxParameterCount" value="5" />
+  <setting rule="AV1561" name="MaxConstructorParameterCount" value="8" />
 </cSharpGuidelinesAnalyzerSettings>
 ```
 

docs/Overview.md

@@ -105,7 +105,8 @@ This analyzer reports when a method, constructor, local function, indexer or del
 - declares a tuple parameter
 - returns a tuple with more than 2 elements.
 
-**Note:** This rule can be customized using a [configuration file](/docs/Configuration.md) by setting **MaxParameterCount** to a value in range 0-255.
+**Note:** This rule can be customized using a [configuration file](/docs/Configuration.md) by setting **MaxParameterCount** and/or **MaxConstructorParameterCount** to a value in range 0-255.
+When **MaxConstructorParameterCount** is omitted, the value from **MaxParameterCount** (or its default) is used for constructors.
 
 ### [AV1562](https://github.com/dennisdoomen/CSharpGuidelines/blob/7a66f7468da6ce1477753a02e416e04bc9a44e45/_pages/1500_MaintainabilityGuidelines.md#av1562): Don't use ref or out parameters ![](/images/warn.png "severity: warning")
 This analyzer reports when:

src/CSharpGuidelinesAnalyzer/CSharpGuidelinesAnalyzer.Test/Specs/Maintainability/AvoidSignatureWithManyParametersSpecs.cs

@@ -740,11 +740,35 @@ internal void When_method_contains_nine_parameters_it_must_be_reported()
         }
 
         [Fact]
-        internal void When_settings_are_corrupt_it_must_use_default_value()
+        internal void When_constructor_contains_nine_parameters_it_must_be_reported()
+        {
+            // Arrange
+            ParsedSourceCode source = new TypeSourceCodeBuilder()
+                .WithSettings(new AnalyzerSettingsBuilder()
+                    .Including(DiagnosticId, "MaxParameterCount", "8"))
+                .InGlobalScope(@"
+                    class C
+                    {
+                        public [|C|](int first, string second, double third, float fourth, byte fifth, char sixth, DateTime seventh, TimeSpan eighth, ushort ninth)
+                        {
+                        }
+                    }
+                ")
+                .Build();
+
+            // Act and assert
+            VerifyGuidelineDiagnostic(source,
+                "Constructor for 'C' contains 9 parameters, which exceeds the maximum of 8 parameters.");
+        }
+
+        [Fact]
+        internal void When_method_contains_nine_parameters_with_constructor_override_it_must_be_reported()
         {
             // Arrange
             ParsedSourceCode source = new MemberSourceCodeBuilder()
-                .WithSettings("*** BAD XML ***")
+                .WithSettings(new AnalyzerSettingsBuilder()
+                    .Including(DiagnosticId, "MaxParameterCount", "8")
+                    .Including(DiagnosticId, "MaxConstructorParameterCount", "4"))
                 .InDefaultClass(@"
                     void [|M|](int first, string second, double third, float fourth, byte fifth, char sixth, DateTime seventh, TimeSpan eighth, ushort ninth)
                     {
@@ -754,49 +778,115 @@ internal void When_settings_are_corrupt_it_must_use_default_value()
 
             // Act and assert
             VerifyGuidelineDiagnostic(source,
+                "Method 'M' contains 9 parameters, which exceeds the maximum of 8 parameters.");
+        }
+
+        [Fact]
+        internal void When_constructor_contains_nine_parameters_with_constructor_override_it_must_be_reported()
+        {
+            // Arrange
+            ParsedSourceCode source = new TypeSourceCodeBuilder()
+                .WithSettings(new AnalyzerSettingsBuilder()
+                    .Including(DiagnosticId, "MaxParameterCount", "4")
+                    .Including(DiagnosticId, "MaxConstructorParameterCount", "8"))
+                .InGlobalScope(@"
+                    class C
+                    {
+                        public [|C|](int first, string second, double third, float fourth, byte fifth, char sixth, DateTime seventh, TimeSpan eighth, ushort ninth)
+                        {
+                        }
+                    }
+                ")
+                .Build();
+
+            // Act and assert
+            VerifyGuidelineDiagnostic(source,
+                "Constructor for 'C' contains 9 parameters, which exceeds the maximum of 8 parameters.");
+        }
+
+        [Fact]
+        internal void When_settings_are_corrupt_it_must_use_default_values()
+        {
+            // Arrange
+            ParsedSourceCode source = new TypeSourceCodeBuilder()
+                .WithSettings("*** BAD XML ***")
+                .InGlobalScope(@"
+                    class C
+                    {
+                        public [|C|](int first, string second, double third, float fourth, byte fifth, char sixth, DateTime seventh, TimeSpan eighth, ushort ninth)
+                        {
+                        }
+
+                        void [|M|](int first, string second, double third, float fourth, byte fifth, char sixth, DateTime seventh, TimeSpan eighth, ushort ninth)
+                        {
+                        }
+                    }
+                ")
+                .Build();
+
+            // Act and assert
+            VerifyGuidelineDiagnostic(source,
+                "Constructor for 'C' contains 9 parameters, which exceeds the maximum of 3 parameters.",
                 "Method 'M' contains 9 parameters, which exceeds the maximum of 3 parameters.");
         }
 
         [Fact]
-        internal void When_setting_is_missing_it_must_use_default_value()
+        internal void When_settings_are_missing_it_must_use_default_values()
         {
             // Arrange
-            ParsedSourceCode source = new MemberSourceCodeBuilder()
+            ParsedSourceCode source = new TypeSourceCodeBuilder()
                 .WithSettings(new AnalyzerSettingsBuilder()
                     .Including(DiagnosticId, "OtherUnusedSetting", "SomeValue"))
-                .InDefaultClass(@"
-                    void [|M|](int first, string second, double third, float fourth, byte fifth, char sixth, DateTime seventh, TimeSpan eighth, ushort ninth)
+                .InGlobalScope(@"
+                    class C
                     {
+                        public [|C|](int first, string second, double third, float fourth, byte fifth, char sixth, DateTime seventh, TimeSpan eighth, ushort ninth)
+                        {
+                        }
+
+                        void [|M|](int first, string second, double third, float fourth, byte fifth, char sixth, DateTime seventh, TimeSpan eighth, ushort ninth)
+                        {
+                        }
                     }
                 ")
                 .Build();
 
             // Act and assert
             VerifyGuidelineDiagnostic(source,
+                "Constructor for 'C' contains 9 parameters, which exceeds the maximum of 3 parameters.",
                 "Method 'M' contains 9 parameters, which exceeds the maximum of 3 parameters.");
         }
 
         [Fact]
-        internal void When_setting_value_is_missing_it_must_use_default_value()
+        internal void When_setting_values_are_missing_it_must_use_default_values()
         {
             // Arrange
-            ParsedSourceCode source = new MemberSourceCodeBuilder()
+            ParsedSourceCode source = new TypeSourceCodeBuilder()
                 .WithSettings(new AnalyzerSettingsBuilder()
-                    .Including(DiagnosticId, "MaxParameterCount", null))
-                .InDefaultClass(@"
-                    void [|M|](int first, string second, double third, float fourth, byte fifth, char sixth, DateTime seventh, TimeSpan eighth, ushort ninth)
+                    .Including(DiagnosticId, "MaxParameterCount", null)
+                    .Including(DiagnosticId, "MaxConstructorParameterCount", null))
+                .InGlobalScope(@"
+                    class C
                     {
+                        public [|C|](int first, string second, double third, float fourth, byte fifth, char sixth, DateTime seventh, TimeSpan eighth, ushort ninth)
+                        {
+                        }
+
+                        void [|M|](int first, string second, double third, float fourth, byte fifth, char sixth, DateTime seventh, TimeSpan eighth, ushort ninth)
+                        {
+                        }
                     }
                 ")
                 .Build();
 
             // Act and assert
             VerifyGuidelineDiagnostic(source,
+                "Constructor for 'C' contains 9 parameters, which exceeds the maximum of 3 parameters.",
                 "Method 'M' contains 9 parameters, which exceeds the maximum of 3 parameters.");
         }
 
         [Fact]
-        internal void When_setting_value_is_out_of_range_it_must_fail()
+        internal void When_parameter_setting_value_is_out_of_range_it_must_fail()
         {
             // Arrange
             ParsedSourceCode source = new MemberSourceCodeBuilder()
@@ -817,6 +907,28 @@ internal void When_setting_value_is_out_of_range_it_must_fail()
                 .WithMessage("*Value for AV1561:MaxParameterCount configuration setting must be in range 0-255.*");
         }
 
+        [Fact]
+        internal void When_constructor_parameter_setting_value_is_out_of_range_it_must_fail()
+        {
+            // Arrange
+            ParsedSourceCode source = new MemberSourceCodeBuilder()
+                .WithSettings(new AnalyzerSettingsBuilder()
+                    .Including(DiagnosticId, "MaxConstructorParameterCount", "-1"))
+                .InDefaultClass(@"
+                    void [|M|](int first, string second, double third, float fourth, byte fifth, char sixth, DateTime seventh, TimeSpan eighth, ushort ninth)
+                    {
+                    }
+                ")
+                .Build();
+
+            // Act
+            Action action = () => VerifyGuidelineDiagnostic(source);
+
+            // Assert
+            action.Should().Throw<Exception>()
+                .WithMessage("*Value for AV1561:MaxConstructorParameterCount configuration setting must be in range 0-255.*");
+        }
+
         #endregion
 
         protected override DiagnosticAnalyzer CreateAnalyzer()

src/CSharpGuidelinesAnalyzer/CSharpGuidelinesAnalyzer/Rules/Maintainability/AvoidMemberWithManyStatementsAnalyzer.cs

@@ -33,6 +33,10 @@ public sealed class AvoidMemberWithManyStatementsAnalyzer : DiagnosticAnalyzer
         [NotNull]
         private static readonly Action<CompilationStartAnalysisContext> RegisterCompilationStartAction = RegisterCompilationStart;
 
+        [NotNull]
+        private static readonly AnalyzerSettingKey MaxStatementCountKey =
+            new AnalyzerSettingKey(DiagnosticId, "MaxStatementCount");
+
         [ItemNotNull]
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);
 
@@ -58,8 +62,7 @@ private static int GetMaxStatementCountFromSettings([NotNull] AnalyzerOptions op
         {
             AnalyzerSettingsRegistry registry = AnalyzerSettingsProvider.LoadSettings(options, cancellationToken);
 
-            var settingKey = new AnalyzerSettingKey(DiagnosticId, "MaxStatementCount");
-            return registry.TryGetInt32(settingKey, 0, 255) ?? DefaultMaxStatementCount;
+            return registry.TryGetInt32(MaxStatementCountKey, 0, 255) ?? DefaultMaxStatementCount;
         }
 
         private static void AnalyzeCodeBlock(CodeBlockAnalysisContext context, int maxStatementCount)