Merge pull request #118 from bkoelman/parameterized-test-methods

Adds detection of parameterized test methods

Author: bkoelman

src/CSharpGuidelinesAnalyzer/CSharpGuidelinesAnalyzer.Test/Specs/Naming/SuffixAsyncMethodCorrectlySpecs.cs

@@ -227,6 +227,50 @@ public async Task When_some_condition_it_must_work()
             VerifyGuidelineDiagnostic(source);
         }
 
+        [Fact]
+        internal void When_parameterized_test_method_name_does_not_end_with_Async_it_must_be_skipped()
+        {
+            // Arrange
+            ParsedSourceCode source = new TypeSourceCodeBuilder()
+                .Using(typeof(Task).Namespace)
+                .InGlobalScope(@"
+                    namespace Xunit
+                    {
+                        public class TheoryAttribute : Attribute
+                        {
+                        }
+
+                        [AttributeUsage(AttributeTargets.Method, AllowMultiple = true)]
+                        public class InlineDataAttribute : Attribute
+                        {
+                            public InlineDataAttribute(params object[] data)
+                            {
+                            }
+                        }
+                    }
+
+                    namespace App
+                    {
+                        using Xunit;
+
+                        class UnitTests
+                        {
+                            [InlineData(""A"")]
+                            [InlineData(""B"")]
+                            [Theory]
+                            public async Task When_some_condition_it_must_work(string value)
+                            {
+                                _ = value;
+                            }
+                        }
+                    }
+                ")
+                .Build();
+
+            // Act and assert
+            VerifyGuidelineDiagnostic(source);
+        }
+
         protected override DiagnosticAnalyzer CreateAnalyzer()
         {
             return new SuffixAsyncMethodCorrectlyAnalyzer();

src/CSharpGuidelinesAnalyzer/CSharpGuidelinesAnalyzer/Extensions/SymbolExtensions.cs

@@ -15,9 +15,10 @@ namespace CSharpGuidelinesAnalyzer.Extensions
     internal static class SymbolExtensions
     {
         [ItemNotNull]
-        private static readonly ImmutableArray<string> UnitTestFrameworkMethodAttributeNames =
-            ImmutableArray.Create("Microsoft.VisualStudio.TestTools.UnitTesting.TestMethodAttribute", "Xunit.FactAttribute",
-                "NUnit.Framework.TestAttribute", "MbUnit.Framework.TestAttribute");
+        private static readonly ImmutableArray<string> UnitTestFrameworkMethodAttributeNames = ImmutableArray.Create(
+            "Microsoft.VisualStudio.TestTools.UnitTesting.TestMethodAttribute",
+            "Microsoft.VisualStudio.TestTools.UnitTesting.DataTestMethod", "Xunit.FactAttribute", "Xunit.TheoryAttribute",
+            "NUnit.Framework.TestAttribute", "NUnit.Framework.TestCaseAttribute", "MbUnit.Framework.TestAttribute");
 
         [NotNull]
         [ItemNotNull]