Fixed: do not report AV1008 on program entry point

Author: Bart Koelman

src/CSharpGuidelinesAnalyzer/CSharpGuidelinesAnalyzer.Test/Specs/ClassDesign/AvoidStaticClassSpecs.cs

@@ -1,5 +1,6 @@
 using CSharpGuidelinesAnalyzer.Rules.ClassDesign;
 using CSharpGuidelinesAnalyzer.Test.TestDataBuilders;
+using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.Diagnostics;
 using Xunit;
 
@@ -298,6 +299,26 @@ static SomeExtensions()
             VerifyGuidelineDiagnostic(source);
         }
 
+        [Fact]
+        internal void When_static_class_contains_entry_point_it_must_be_skipped()
+        {
+            // Arrange
+            ParsedSourceCode source = new TypeSourceCodeBuilder()
+                .WithOutputKind(OutputKind.WindowsApplication)
+                .InGlobalScope(@"
+                    static class Program
+                    {
+                        static void Main(string[] args)
+                        {
+                        }
+                    }
+                ")
+                .Build();
+
+            // Act and assert
+            VerifyGuidelineDiagnostic(source);
+        }
+
         protected override DiagnosticAnalyzer CreateAnalyzer()
         {
             return new AvoidStaticClassAnalyzer();

src/CSharpGuidelinesAnalyzer/CSharpGuidelinesAnalyzer/Extensions/SymbolExtensions.cs

@@ -370,5 +370,14 @@ public static string MemberNameWithoutExplicitInterfacePrefix([NotNull] this ISy
             int index = symbol.Name.LastIndexOf(".", StringComparison.Ordinal);
             return index != -1 ? symbol.Name.Substring(index + 1) : symbol.Name;
         }
+
+        public static bool IsEntryPoint([NotNull] this IMethodSymbol method, [NotNull] Compilation compilation,
+            CancellationToken cancellationToken)
+        {
+            IMethodSymbol entryPoint =
+                method.MethodKind == MethodKind.Ordinary ? compilation.GetEntryPoint(cancellationToken) : null;
+
+            return Equals(method, entryPoint);
+        }
     }
 }

src/CSharpGuidelinesAnalyzer/CSharpGuidelinesAnalyzer/Rules/ClassDesign/AvoidStaticClassAnalyzer.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Linq;
+using System.Threading;
 using CSharpGuidelinesAnalyzer.Extensions;
 using JetBrains.Annotations;
 using Microsoft.CodeAnalysis;
@@ -62,14 +63,23 @@ private static void AnalyzeNamedType(SymbolAnalysisContext context)
 
             if (!type.Name.EndsWith("Extensions", StringComparison.Ordinal))
             {
-                context.ReportDiagnostic(Diagnostic.Create(TypeRule, type.Locations[0], type.Name));
+                if (!TypeContainsEntryPoint(type, context.Compilation, context.CancellationToken))
+                {
+                    context.ReportDiagnostic(Diagnostic.Create(TypeRule, type.Locations[0], type.Name));
+                }
             }
             else
             {
                 AnalyzeTypeMembers(type, context);
             }
         }
 
+        private static bool TypeContainsEntryPoint([NotNull] INamedTypeSymbol type, [NotNull] Compilation compilation,
+            CancellationToken cancellationToken)
+        {
+            return type.GetMembers().OfType<IMethodSymbol>().Any(method => method.IsEntryPoint(compilation, cancellationToken));
+        }
+
         private static void AnalyzeTypeMembers([NotNull] INamedTypeSymbol type, SymbolAnalysisContext context)
         {
             IEnumerable<ISymbol> accessibleMembers = type.GetMembers().Where(IsPublicOrInternal)

src/CSharpGuidelinesAnalyzer/CSharpGuidelinesAnalyzer/Rules/Naming/SuffixAsyncMethodCorrectlyAnalyzer.cs

@@ -69,16 +69,7 @@ private static bool RequiresReport([NotNull] IMethodSymbol method, [NotNull] Com
             CancellationToken cancellationToken)
         {
             return method.IsAsync && !method.Name.EndsWith("Async", StringComparison.Ordinal) && !method.IsSynthesized() &&
-                !IsEntryPoint(method, compilation, cancellationToken);
-        }
-
-        private static bool IsEntryPoint([NotNull] IMethodSymbol method, [NotNull] Compilation compilation,
-            CancellationToken cancellationToken)
-        {
-            IMethodSymbol entryPoint =
-                method.MethodKind == MethodKind.Ordinary ? compilation.GetEntryPoint(cancellationToken) : null;
-
-            return Equals(method, entryPoint);
+                !method.IsEntryPoint(compilation, cancellationToken);
         }
 
         private static void ReportAt([NotNull] IMethodSymbol method, [NotNull] Action<Diagnostic> reportDiagnostic)