Skip to content

Commit 48ccfae

Browse files
liamaharonggwpezjoepetrowskiacatangiu
authored
Update Runtime Weights (polkadot-fellows#129)
For polkadot-fellows#68 (comment). Uses instructions introduced to the readme in polkadot-fellows#127 to re-bench all runtimes. TODO - [x] Is this much change % expected? Is benchmarking on vCPUs flawed because they are arbitrarily shared with other cloud customers? - It seems to be fine, the changes align with actual changes in configuration of the runtimes (thanks @ggwpez!). - [x] Polkadot - [x] Kusama - [x] Asset Hub Polkadot - [x] Asset Hub Kusama - [x] Bridge Hub Polkadot - [x] Bridge Hub Kusama - [x] Collectives Polkadot - [ ] Look into why subweight shows some errors ## Polkadot Changes <img width="1085" alt="Screenshot 2023-12-19 at 11 06 20" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/272e2ecd-48da-4ebb-b6e2-ff9fd73683fe"> <img width="1085" alt="Screenshot 2023-12-19 at 11 08 24" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/a37dea2e-abf6-4ad8-b3ef-abed6cb3e955"> <img width="1085" alt="Screenshot 2023-12-19 at 11 10 14" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/08788059-a052-4af6-b2aa-c791a3cddc24"> ## Kusama Changes <img width="1074" alt="Screenshot 2023-12-19 at 11 12 19" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/b096d1ec-384f-436f-ae9c-f6f929d14b9b"> <img width="1074" alt="Screenshot 2023-12-19 at 11 12 43" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/1bc757e8-c00c-4cf0-bea6-f74b92a33355"> ## Asset Hub Polkadot Changes <img width="1313" alt="Screenshot 2023-12-19 at 20 34 25" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/ea658d57-365d-45de-b0be-2c4627783e64"> ## Asset Hub Kusama Changes <img width="1313" alt="Screenshot 2023-12-19 at 20 43 37" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/963483ee-0d9f-49dc-9a83-31b443df1f10"> ## Bridge Hub Polkadot <img width="1313" alt="Screenshot 2023-12-20 at 11 49 13" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/0da77515-bb36-4a41-9c88-463ea28d9a9e"> ## Bridge Hub Kusama <img width="1313" alt="Screenshot 2023-12-20 at 11 48 39" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/97c7efa4-6a22-42fe-90e0-8477e0628d00"> ## Collectives Polkadot <img width="1369" alt="Screenshot 2023-12-20 at 11 50 33" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/6b2b22f3-fc87-4f19-a126-8d4be2335aa6"> <img width="1369" alt="Screenshot 2023-12-20 at 11 51 07" src="https://github.com/polkadot-fellows/runtimes/assets/16665596/168ec1e2-ec47-4213-8899-f2d51c8ec6d1"> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]>
1 parent 3caec69 commit 48ccfae

File tree

193 files changed

+8377
-12539
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

193 files changed

+8377
-12539
lines changed

integration-tests/emulated/assets/asset-hub-kusama/src/tests/reserve_transfer.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ fn relay_origin_assertions(t: RelayToSystemParaTest) {
3636
}
3737

3838
fn system_para_dest_assertions_incomplete(_t: RelayToSystemParaTest) {
39-
AssetHubKusama::assert_dmp_queue_incomplete(None, Some(Error::UntrustedReserveLocation));
39+
AssetHubKusama::assert_dmp_queue_incomplete(Some(Error::WeightNotComputable));
4040
}
4141

4242
fn system_para_to_relay_assertions(_t: SystemParaToRelayTest) {

integration-tests/emulated/assets/asset-hub-polkadot/src/tests/reserve_transfer.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ fn relay_origin_assertions(t: RelayToSystemParaTest) {
3636
}
3737

3838
fn system_para_dest_assertions_incomplete(_t: RelayToSystemParaTest) {
39-
AssetHubPolkadot::assert_dmp_queue_incomplete(None, Some(Error::UntrustedReserveLocation));
39+
AssetHubPolkadot::assert_dmp_queue_incomplete(Some(Error::WeightNotComputable));
4040
}
4141

4242
fn system_para_to_relay_assertions(_t: SystemParaToRelayTest) {

integration-tests/emulated/assets/asset-hub-polkadot/src/tests/teleport.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ fn relay_dest_assertions(t: SystemParaToRelayTest) {
4545
Polkadot::assert_ump_queue_processed(
4646
true,
4747
Some(AssetHubPolkadot::para_id()),
48-
Some(Weight::from_parts(370_000_000, 7_000)),
48+
Some(Weight::from_parts(254_182_000, 7_186)),
4949
);
5050

5151
assert_expected_events!(
@@ -68,7 +68,7 @@ fn relay_dest_assertions_fail(_t: SystemParaToRelayTest) {
6868
Polkadot::assert_ump_queue_processed(
6969
false,
7070
Some(AssetHubPolkadot::para_id()),
71-
Some(Weight::from_parts(235_000_000, 3_500)),
71+
Some(Weight::from_parts(122_581_000, 3_593)),
7272
);
7373
}
7474

integration-tests/emulated/common/src/impls.rs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -474,20 +474,14 @@ macro_rules! impl_assert_events_helpers_for_parachain {
474474

475475
/// Asserts a XCM from Relay Chain is incompletely executed
476476
pub fn assert_dmp_queue_incomplete(
477-
expected_weight: Option<$crate::impls::Weight>,
478477
expected_error: Option<$crate::impls::Error>,
479478
) {
480479
$crate::impls::assert_expected_events!(
481480
Self,
482481
vec![
483482
[<$chain RuntimeEvent>]::DmpQueue($crate::impls::cumulus_pallet_dmp_queue::Event::ExecutedDownward {
484-
outcome: $crate::impls::Outcome::Incomplete(weight, error), ..
483+
outcome: $crate::impls::Outcome::Error(error), ..
485484
}) => {
486-
weight: $crate::impls::weight_within_threshold(
487-
($crate::impls::REF_TIME_THRESHOLD, $crate::impls::PROOF_SIZE_THRESHOLD),
488-
expected_weight.unwrap_or(*weight),
489-
*weight
490-
),
491485
error: *error == expected_error.unwrap_or(*error),
492486
},
493487
]

relay/kusama/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ impl pallet_balances::Config for Runtime {
327327
type MaxLocks = MaxLocks;
328328
type MaxReserves = MaxReserves;
329329
type ReserveIdentifier = [u8; 8];
330-
type WeightInfo = weights::pallet_balances::WeightInfo<Runtime>;
330+
type WeightInfo = weights::pallet_balances_balances::WeightInfo<Runtime>;
331331
type FreezeIdentifier = RuntimeFreezeReason;
332332
type MaxFreezes = ConstU32<8>;
333333
type RuntimeHoldReason = RuntimeHoldReason;

relay/kusama/src/weights/frame_benchmarking_baseline.rs

Lines changed: 30 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

relay/kusama/src/weights/frame_election_provider_support.rs

Lines changed: 28 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

relay/kusama/src/weights/frame_system.rs

Lines changed: 41 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)