Skip to content

Commit d166a64

Browse files
committed
refactor(node): rename rd3tProps.data -> rd3tProps.nodeDatum
1 parent 290fd8a commit d166a64

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

demo/src/App.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@ const customNodeFnMapping = {
2424
description: 'PureSvgNodeElement - Pure SVG node & label (IE11 compatible)',
2525
fn: (rd3tProps, appState) => (
2626
<PureSvgNodeElement
27-
nodeDatum={rd3tProps.data}
27+
nodeDatum={rd3tProps.nodeDatum}
2828
toggleNode={rd3tProps.toggleNode}
2929
orientation={appState.orientation}
3030
/>
3131
),
3232
},
3333
mixed: {
3434
description: 'MixedNodeElement - SVG `circle` + `foreignObject` label',
35-
fn: ({ data, toggleNode }, appState) => (
35+
fn: ({ nodeDatum, toggleNode }, appState) => (
3636
<MixedNodeElement
37-
nodeData={data}
37+
nodeData={nodeDatum}
3838
triggerNodeToggle={toggleNode}
3939
foreignObjectProps={{
4040
width: appState.nodeSize.x,

src/Node/DefaultNodeElement.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export interface DefaultNodeElementProps extends CustomNodeElementProps {
1919
}
2020

2121
const DefaultNodeElement: React.FunctionComponent<DefaultNodeElementProps> = ({
22-
data,
22+
nodeDatum,
2323
toggleNode,
2424
onNodeClick,
2525
onNodeMouseOver,
@@ -37,11 +37,11 @@ const DefaultNodeElement: React.FunctionComponent<DefaultNodeElementProps> = ({
3737
></circle>
3838
<g className="rd3t-label">
3939
<text className="rd3t-label__title" {...textLayout.title}>
40-
{data.name}
40+
{nodeDatum.name}
4141
</text>
4242
<text className="rd3t-label__attributes">
43-
{data.attributes &&
44-
Object.entries(data.attributes).map(([labelKey, labelValue], i) => (
43+
{nodeDatum.attributes &&
44+
Object.entries(nodeDatum.attributes).map(([labelKey, labelValue], i) => (
4545
<tspan key={`${labelKey}-${i}`} {...textLayout.attribute}>
4646
{labelKey}: {labelValue}
4747
</tspan>

src/Node/index.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,14 +113,15 @@ export default class Node extends React.Component<NodeProps, NodeState> {
113113
this.applyTransform(transform, transitionDuration);
114114
}
115115

116+
// TODO: needs tests
116117
renderNodeElement = () => {
117118
const { data, renderCustomNodeElement } = this.props;
118119
if (typeof renderCustomNodeElement === 'function') {
119-
return renderCustomNodeElement({ data, toggleNode: this.handleNodeToggle });
120+
return renderCustomNodeElement({ nodeDatum: data, toggleNode: this.handleNodeToggle });
120121
}
121122

122123
return DefaultNodeElement({
123-
data,
124+
nodeDatum: data,
124125
toggleNode: this.handleNodeToggle,
125126
onNodeClick: this.handleOnClick,
126127
onNodeMouseOver: this.handleOnMouseOver,

src/types/common.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export type PathClassFunction = PathFunction;
3434
export type SyntheticEventHandler = (evt: React.SyntheticEvent) => void;
3535

3636
export interface CustomNodeElementProps {
37-
data: TreeNodeDatum;
37+
nodeDatum: TreeNodeDatum;
3838
toggleNode: () => void;
3939
}
4040

0 commit comments

Comments
 (0)