driver: only apply default cephFSClientType when unset

black-dragon74 · black-dragon74 · commit 6b348386bfa3 · 2025-10-03T17:00:25.000+05:30
Fix a bug where `driver.cephFSClientType` was always overwritten by the default value from `OperatorConfig`. The field is now populated from defaults only if it is not already set in the driver spec. Fixes: ceph#337 Signed-off-by: Niraj Yadav <niryadav@redhat.com>
diff --git a/internal/controller/driver_controller.go b/internal/controller/driver_controller.go
@@ -1849,7 +1849,7 @@ func mergeDriverSpecs(dest, src *csiv1.DriverSpec) {
 	if dest.FuseMountOptions == nil {
 		dest.FuseMountOptions = src.FuseMountOptions
 	}
-	if src.CephFsClientType != "" {
+	if dest.CephFsClientType == "" {
 		dest.CephFsClientType = src.CephFsClientType
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -1849,7 +1849,7 @@ func mergeDriverSpecs(dest, src *csiv1.DriverSpec) {`
`1849`	`1849`	`if dest.FuseMountOptions == nil {`
`1850`	`1850`	`dest.FuseMountOptions = src.FuseMountOptions`
`1851`	`1851`	`}`
`1852`		`- if src.CephFsClientType != "" {`
	`1852`	`+ if dest.CephFsClientType == "" {`
`1853`	`1853`	`dest.CephFsClientType = src.CephFsClientType`
`1854`	`1854`	`}`
`1855`	`1855`	`}`