Skip to content

Commit 87ea0df

Browse files
committed
Fix date format in query string in QueryChangesets()
1 parent ce9e63f commit 87ea0df

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

FunctionalTests/Tests.cs

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ public static class Tests
1414
{
1515
private static Bounds WashingtonDC = new Bounds()
1616
{
17-
MinLongitude = -77.0371918f,
18-
MinLatitude = 38.9067186f,
19-
MaxLongitude = -77.03599990f,
20-
MaxLatitude = 38.907734f,
17+
MinLongitude = -77.0671918f,
18+
MinLatitude = 38.9007186f,
19+
MaxLongitude = -77.00099990f,
20+
MaxLatitude = 38.98734f,
2121
};
2222

2323
private static Bounds TraceArea = new Bounds()
@@ -65,22 +65,25 @@ public static async Task TestClient(INonAuthClient client)
6565
var wayComplete = await client.GetCompleteWay(wayId);
6666
var relation = await client.GetRelation(relationId);
6767
var relationComplete = await client.GetCompleteRelation(relationId);
68-
var nodeVersion = await client.GetNodeVersion(nodeId, 3);
68+
var nodeVersion = await client.GetNodeVersion(nodeId, 1);
6969
NotNull(node, way, wayComplete, relation, relationComplete, nodeVersion);
7070
var nodeHistory = await client.GetNodeHistory(nodeId);
7171
var multifetchNodes = await client.GetNodes(new Dictionary<long, long?>() { { nodeId, null }, { nodeId + 1, 1 } });
7272
var nodeRelations = await client.GetNodeRelations(nodeId);
7373
var nodeWays = await client.GetNodeWays(nodeId);
7474
var multifetchElements = await client.GetElements(
7575
map.Nodes.Select(n => new OsmGeoKey(n)).Concat(map.Ways.Select(n => new OsmGeoKey(n))).ToArray());
76-
True(nodeHistory?.Any(), multifetchNodes?.Any(), nodeRelations?.Any(), nodeWays?.Any(), multifetchElements?.Any());
76+
True(nodeHistory?.Any(), multifetchNodes?.Any());
77+
NotNull(nodeRelations, nodeWays, multifetchElements);
7778
var changeset = await client.GetChangeset(node.ChangeSetId.Value);
7879
var changesetWithDiscussion = await client.GetChangeset(node.ChangeSetId.Value, true);
7980
NotNull(changeset, changesetWithDiscussion?.Discussion);
8081
var changesets = await client.QueryChangesets(WashingtonDC, null, null, null, null, false, false, null);
8182
True(changesets?.Any());
8283
changesets = await client.QueryChangesets(null, node.UserId, null, null, null, false, false, null);
8384
True(changesets?.Any());
85+
changesets = await client.QueryChangesets(null, node.UserId, null, DateTime.UtcNow.AddDays(-3), null, false, false, null);
86+
True(changesets?.Any());
8487
changesets = await client.QueryChangesets(null, null, node.UserName, null, null, false, false, null);
8588
True(changesets?.Any());
8689
changesets = await client.QueryChangesets(null, null, null, null, null, false, false, new long[] { 151176, 151177 });

src/NonAuthClient.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
using System.Web;
1515
using Microsoft.Extensions.Logging;
1616
using OsmSharp.Db;
17+
using System.Globalization;
1718

1819
namespace OsmSharp.IO.API
1920
{
@@ -489,8 +490,8 @@ public async Task<Changeset[]> QueryChangesets(Bounds bounds, long? userId, stri
489490
if (bounds != null) query["bbox"] = ToString(bounds);
490491
if (userId.HasValue) query["user"] = userId.ToString();
491492
if (userName != null) query["display_name"] = userName;
492-
if (minClosedDate.HasValue) query["time"] = minClosedDate.ToString();
493-
if (maxOpenedDate.HasValue) query.Add("time", maxOpenedDate.ToString());
493+
if (minClosedDate.HasValue) query["time"] = FormatNoteDate(minClosedDate.Value);
494+
if (maxOpenedDate.HasValue) query.Add("time", FormatNoteDate(maxOpenedDate.Value));
494495
if (openOnly) query["open"] = "true";
495496
if (closedOnly) query["closed"] = "true";
496497
if (ids != null) query["changesets"] = string.Join(",", ids);

0 commit comments

Comments
 (0)