Provide interfaces #1 - Seems like there's a need to use the interfaces in the factory as well to allow testing.

Author: HarelM

FunctionalTests/Tests.cs

@@ -49,7 +49,7 @@ public static class Tests
 			Visibility = Visibility.Public,
 		};
 
-		public static async Task TestClient(NonAuthClient client)
+		public static async Task TestClient(INonAuthClient client)
 		{
 			var capabilities = await client.GetCapabilities();
 			var apiVersion = await client.GetVersions();
@@ -110,7 +110,7 @@ public static async Task TestClient(NonAuthClient client)
 				newNote?.Status == Note.NoteStatus.Open);
 		}
 
-		public static async Task TestAuthClient(AuthClient client)
+		public static async Task TestAuthClient(IAuthClient client)
 		{
 			var permissions = await client.GetPermissions();
 			True(permissions?.UserPermission?.Any());

src/ClientsFactory.cs

@@ -21,19 +21,19 @@ public ClientsFactory(ILogger logger, HttpClient httpClient, string baseAddress)
         }
 
         /// <inheritdoc/>
-        public NonAuthClient CreateNonAuthClient()
+        public INonAuthClient CreateNonAuthClient()
         {
             return new NonAuthClient(_baseAddress, _httpClient, _logger);
         }
 
         /// <inheritdoc/>
-        public AuthClient CreateBasicAuthClient(string username, string password)
+        public IAuthClient CreateBasicAuthClient(string username, string password)
         {
             return new BasicAuthClient(_httpClient, _logger, _baseAddress, username, password);
         }
 
         /// <inheritdoc/>
-        public AuthClient CreateOAuthClient(string consumerKey, string consumerSecret, string token, string tokenSecret)
+        public IAuthClient CreateOAuthClient(string consumerKey, string consumerSecret, string token, string tokenSecret)
         {
             return new OAuthClient(_httpClient, _logger, _baseAddress, consumerKey, consumerSecret, token, tokenSecret);
         }

src/IClientsFactory.cs

@@ -10,14 +10,14 @@ public interface IClientsFactory
         /// Creates a client that does not need authentication and thus can't perform authenticated operations
         /// </summary>
         /// <returns></returns>
-        NonAuthClient CreateNonAuthClient();
+        INonAuthClient CreateNonAuthClient();
         /// <summary>
         /// Creates a client that needs user name and password credentials
         /// </summary>
         /// <param name="username"></param>
         /// <param name="password"></param>
         /// <returns></returns>
-        AuthClient CreateBasicAuthClient(string username, string password);
+        IAuthClient CreateBasicAuthClient(string username, string password);
         /// <summary>
         /// Creates a client that will use OAuth 1.0 credentials provided from the OAuth OSM page
         /// </summary>
@@ -26,6 +26,6 @@ public interface IClientsFactory
         /// <param name="token"></param>
         /// <param name="tokenSecret"></param>
         /// <returns></returns>
-        AuthClient CreateOAuthClient(string consumerKey, string consumerSecret, string token, string tokenSecret);
+        IAuthClient CreateOAuthClient(string consumerKey, string consumerSecret, string token, string tokenSecret);
     }
 }