Skip to content

Commit 602d290

Browse files
committed
Some remarks re: errors.
1 parent 407d58d commit 602d290

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

mainwindow.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,9 @@ CMainWindow::CMainWindow(const Glib::RefPtr<Gtk::Application>& app) : Gtk::Appli
124124
} else {
125125
/* without a headerbar, we also need to have a vbox for the classic menu here */
126126
cm.view.set_label("View");
127-
cm.view.set_submenu(appmenu);
127+
// TODO: this results in Gtk-CRITICALs on quit as appmenu elements are double freed.
128+
// Is there any way we can set a submenu here without making free of cm.view recursively free appmenu?
129+
cm.view.set_submenu(appmenu);
128130
cm.mbar.append(cm.view);
129131
cm.menu_box.pack_start(cm.mbar,Gtk::PACK_SHRINK);
130132
cm.menu_box.pack_start(split);

0 commit comments

Comments
 (0)