Skip to content

Commit a2ed0cd

Browse files
committed
Resolving thread duplication bug by removing lingering callbacks during JWT refresh
1 parent 3290b29 commit a2ed0cd

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

src/infrastructure/getStore.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { createStore, applyMiddleware, compose } from 'redux';
22
import { createLogger } from 'redux-logger';
33
import { Iterable } from 'immutable';
44
import createSagaMiddleware from 'redux-saga';
5-
// import { getQuery } from '../utility';
5+
import { getQuery } from '../utility';
66
import reducers from './reducers';
77
import initSagas from './initSagas';
88

@@ -20,7 +20,9 @@ const logger = createLogger({
2020
const getStore = () => {
2121
const sagaMiddleware = createSagaMiddleware();
2222
const middleWares = [sagaMiddleware];
23-
middleWares.push(logger);
23+
if (getQuery().logger) {
24+
middleWares.push(logger);
25+
}
2426
const composables = [applyMiddleware(...middleWares)];
2527
const enhancer = compose(...composables);
2628
const store = createStore(

src/infrastructure/network.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const whitelist = [
88
'api/auth',
99
`${TUMBLR_CLIENT_BASE_URL}`
1010
];
11-
const refreshSubscribers = [];
11+
let refreshSubscribers = [];
1212
let isRefreshing = false;
1313

1414
function isPathInWhitelist(url) {
@@ -19,6 +19,7 @@ function subscribeTokenRefresh(cb) {
1919
}
2020
function onTokenRefreshed(token) {
2121
refreshSubscribers.map(cb => cb(token));
22+
refreshSubscribers = [];
2223
}
2324
function refreshAccessToken(error) {
2425
return axios

0 commit comments

Comments
 (0)