Build error for hosted platform

[lenvm]

I encountered a build error while trying to build commit cae88d6 on main for the hosted platform.

I used:
make PROBE_HOST=hosted

Returns:

 GEN      include/version.h
  CC      target/adiv5.c
target/adiv5.c:530:83: error: format specifies type 'unsigned short' but the argument has type 'unsigned int' [-Werror,-Wformat]
                                "Patching Designer code 0x%03" PRIx16 " -> 0x%03" PRIx16 "\n", designer_code, JEP106_MANUFACTURER_STM);
                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
./target/jep106.h:60:42: note: expanded from macro 'JEP106_MANUFACTURER_STM'
#define JEP106_MANUFACTURER_STM          0x020U /* STMicroelectronics */
                                         ^~~~~~
include/general.h:107:41: note: expanded from macro 'DEBUG_WARN'
#define DEBUG_WARN(...)   debug_warning(__VA_ARGS__)
                                        ^~~~~~~~~~~
1 error generated.
make[1]: *** [Makefile:128: adiv5.o] Error 1
make: *** [Makefile:22: all] Error 2

[dragonmux]

We wondered if that would be a problem when reviewing the format strings - you should be able to fix that by substituting " PRIx16 " for u, creating the string "Patching Designer code 0x%03" PRIx16 " -> 0x%03u\n"

if you want to submit a PR with that we'll be happy to merge it

[lenvm]

The suggested change ("Patching Designer code 0x%03" PRIx16 " -> 0x%03u\n", designer_code, JEP106_MANUFACTURER_STM);) leads to the following output of make PROBE_HOST=hosted:

 GEN      include/version.h
  CC      target/adiv5.c
  CC      target/adiv5_jtagdp.c
  CC      target/adiv5_swdp.c
  CC      command.c
  CC      target/cortexa.c
  CC      target/cortexm.c
  CC      crc32.c
  CC      target/efm32.c
  CC      exception.c
  CC      platforms/hosted/gdb_if.c
  CC      gdb_main.c
  CC      gdb_hostio.c
  CC      gdb_packet.c
  CC      target/gdb_reg.c
  CC      hex_utils.c
  CC      target/jtag_devs.c
  CC      target/jtag_scan.c
  CC      target/lmi.c
  CC      target/lpc_common.c
  CC      target/lpc11xx.c
  CC      target/lpc17xx.c
  CC      target/lpc15xx.c
  CC      target/lpc40xx.c
  CC      target/lpc43xx.c
  CC      target/lpc546xx.c
  CC      target/lpc55xx.c
  CC      target/kinetis.c
  CC      main.c
  CC      morse.c
  CC      target/msp432.c
  CC      target/nrf51.c
  CC      target/nxpke04.c
  CC      platforms/hosted/platform.c
  CC      remote.c
  CC      target/rp.c
  CC      target/sam3x.c
  CC      target/sam4l.c
  CC      target/samd.c
  CC      target/samx5x.c
  CC      target/sfdp.c
  CC      target/stm32f1.c
  CC      target/ch32f1.c
  CC      target/stm32f4.c
  CC      target/stm32h7.c
  CC      target/stm32l0.c
  CC      target/stm32l4.c
  CC      target/stm32g0.c
  CC      target/renesas.c
  CC      target/target.c
  CC      target/target_flash.c
  CC      target/target_probe.c
  CC      platforms/hosted/serial_unix.c
platforms/hosted/serial_unix.c:75:5: error: conflicting types for 'serial_open'
int serial_open(const bmda_cli_options_s *cl_opts, const char *serial)
    ^
platforms/hosted/cli.h:74:6: note: previous declaration is here
bool serial_open(const bmda_cli_options_s *opt, const char *serial);
     ^
1 error generated.
make[1]: *** [Makefile:128: serial_unix.o] Error 1
make: *** [Makefile:22: all] Error 2

[dragonmux]

Ah, our bad - this is because you're building on macos and nobody adjusted serial_open() there - the patch you'll need to apply is to change all return -1; in the #ifdef __APPLE__ branch to return false;, and the return type to bool.