fix 8.4 deprecation in traceresponse propagator (open-telemetry#321)

brettmc · web-flow · commit 9948a013522c · 2025-01-08T12:09:44.000+11:00
diff --git a/src/Propagation/TraceResponse/composer.json b/src/Propagation/TraceResponse/composer.json
@@ -27,13 +27,14 @@
     "phpunit/phpunit": "^9.5",
     "vimeo/psalm": "^5.0",
     "symfony/http-client": "^5.4|^6.0",
-    "guzzlehttp/promises": "^1.5",
+    "guzzlehttp/promises": "^2",
     "php-http/message-factory": "^1.0",
     "nyholm/psr7": "^1.5"
   },
   "config": {
     "allow-plugins": {
-      "php-http/discovery": true
+      "php-http/discovery": true,
+      "tbachert/spi": true
     }
   }
 }
diff --git a/src/Propagation/TraceResponse/src/ResponsePropagator.php b/src/Propagation/TraceResponse/src/ResponsePropagator.php
@@ -20,5 +20,5 @@ interface ResponsePropagator
      *
      * @param mixed $carrier
      */
-    public function inject(&$carrier, PropagationSetterInterface $setter = null, ContextInterface $context = null): void;
+    public function inject(&$carrier, ?PropagationSetterInterface $setter = null, ?ContextInterface $context = null): void;
 }

Original file line number	Diff line number	Diff line change
`@@ -20,5 +20,5 @@ interface ResponsePropagator`
`20`	`20`	`*`
`21`	`21`	`* @param mixed $carrier`
`22`	`22`	`*/`
`23`		`- public function inject(&$carrier, PropagationSetterInterface $setter = null, ContextInterface $context = null): void;`
	`23`	`+ public function inject(&$carrier, ?PropagationSetterInterface $setter = null, ?ContextInterface $context = null): void;`
`24`	`24`	`}`