Skip to content

Commit ac859b2

Browse files
authored
Use ->ip as client address and REMOTE_ADDR as network peer address (open-telemetry#337)
1 parent 65e9f30 commit ac859b2

File tree

1 file changed

+2
-1
lines changed
  • src/Instrumentation/Laravel/src/Hooks/Illuminate/Contracts/Http

1 file changed

+2
-1
lines changed

src/Instrumentation/Laravel/src/Hooks/Illuminate/Contracts/Http/Kernel.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,12 @@ protected function hookHandle(): bool
6161
->setAttribute(TraceAttributes::HTTP_REQUEST_BODY_SIZE, $request->header('Content-Length'))
6262
->setAttribute(TraceAttributes::URL_SCHEME, $request->getScheme())
6363
->setAttribute(TraceAttributes::NETWORK_PROTOCOL_VERSION, $request->getProtocolVersion())
64-
->setAttribute(TraceAttributes::NETWORK_PEER_ADDRESS, $request->ip())
64+
->setAttribute(TraceAttributes::NETWORK_PEER_ADDRESS, $request->server('REMOTE_ADDR'))
6565
->setAttribute(TraceAttributes::URL_PATH, $this->httpTarget($request))
6666
->setAttribute(TraceAttributes::SERVER_ADDRESS, $this->httpHostName($request))
6767
->setAttribute(TraceAttributes::SERVER_PORT, $request->getPort())
6868
->setAttribute(TraceAttributes::CLIENT_PORT, $request->server('REMOTE_PORT'))
69+
->setAttribute(TraceAttributes::CLIENT_ADDRESS, $request->ip())
6970
->setAttribute(TraceAttributes::USER_AGENT_ORIGINAL, $request->userAgent())
7071
->startSpan();
7172
$request->attributes->set(SpanInterface::class, $span);

0 commit comments

Comments
 (0)