PDS: Implement com.atproto.repo.importRepo

[rudyfraser]

[afbase]

I think I'd like to try implementing this one :-)

[rudyfraser]

Hell yeah! Go for it — very needed for the production launch and I haven’t heard anyone commit to working on this yet *Rudy Fraser* *(Pronouns: he/him) * Linkedin <https://www.linkedin.com/in/rudy-fraser/> • Bluesky <https://bsky.app/profile/rudyfraser.com> • Trailblazer <https://trailblazer.me/id/rudy-fraser> • Calendly (book time with me) <https://calendly.com/rudyfraser>

…

On Tue, Jan 21, 2025 at 12:41 PM Clinton Bowen ***@***.***> wrote: I think I'd like to try implementing this one :-) — Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLLVQDEMPZ3FW2UMEEJDLL2L2BDHAVCNFSM6AAAAABSWAP5KSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBVGM3DMNZQGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[afbase]

say less!

[afbase]

Okay maybe say a little more:

Auth Verifier

1. For the DPOP Proof of Possession that is still left TODO, would you like this to be implemented as part of this? IDK off hand if it is necessary or not for the import repo xrpc

ActorStoreTransactor

2. I know i've seen ActorStore elsewhere and I am wondering it is overloaded and a reused term/object. In the typescript implement of importRepo, it uses an ActorStoreTransactor. We would need to implement the "actor-store" module in say a new folder rsky-pds/src/actor-store, yes?

I think those two questions largely cover the basis of me getting started on this.

[rudyfraser]

You can ignore DPOP for now. That's oauth related and not necessary specifically for importRepo

In the Typescript there's an ActorStoreReader and ActorStoreTransactor for reading from and writing to an individual did's database which is stored as an on-disk sqlite db as I understand it. I didn't like that for rsky and didn't think it was necessary since everything would be in the same postgres db so I combined the readers and transactors into ActorStore.

Additions may need to be made to rsky's Actor Store but shouldn't need a new implementation unless you would recommend it.

[afbase]

Some of your recent commits has helped out quite a bit so thank you!

I have a very early non-working draft of a commit that I need to refactor and tidy up a bit: afbase@3fcf136

I hope to have something PR ready next week or so. I may have some questions soon that might help me with direction/guidance.

[afbase]

Looks like this will get closed with #57

I will hold on on further work and see what else I can contribute to.

[afbase]

If there are other areas of focus you'd like me to work on, let me know!

[afbase]

I think this can be closed