Skip to content

Commit 7cbf102

Browse files
authored
Issue 599: Connect not working on Android (#601)
* support checking h264 and notifying user * add boolean to toggle enableH264Encoding and add docs * address commas and semicolons in failing test * remove unnecessary comma * pass encodingParameters * remove spacing * address comments * move map builder * be more explicit in comment * move it to a different place * Change to return a list of supported codecs * check enableH264Codec in map before getting it
1 parent 052e4ae commit 7cbf102

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

android/src/main/java/com/twiliorn/library/CustomTwilioVideoViewManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public void receiveCommand(CustomTwilioVideoView view, int commandId, @Nullable
8585
boolean maintainVideoTrackInBackground = args.getBoolean(7);
8686
String cameraType = args.getString(8);
8787
ReadableMap encodingParameters = args.getMap(9);
88-
boolean enableH264Codec = encodingParameters.getBoolean("enableH264Codec");
88+
boolean enableH264Codec = encodingParameters.hasKey("enableH264Codec") ? encodingParameters.getBoolean("enableH264Codec") : false;
8989
view.connectToRoomWrapper(
9090
roomName,
9191
accessToken,

0 commit comments

Comments
 (0)