Support updating reactions

Author: blahgeek

README.md

@@ -91,6 +91,7 @@ Some other keybindings or commands:
 - `C-c C-o`: open this pull request in browser
 - `C-c C-q`: request reviewers
 - `C-c C-l`: set labels
+- `C-c C-j`: set reactions (emojis) for comment or description under current point
 - `C-c C-f`: view current file; invoke with `C-u` prefix to select head or base
 - `C-c C-d`: open current diff; invoke with `C-u` prefix to select file
 - `M-x pr-review-select-commit`: select only some commits for review

pr-review-action.el

@@ -614,5 +614,31 @@ Return t if found, nil otherwise."
                 .commit.oid)))))
   (pr-review-refresh))
 
+(defun pr-review-update-reactions ()
+  "Interactively select reactions for comment or description under point."
+  (interactive)
+  (let* ((section (magit-current-section))
+         (all-reaction-names (mapcar (lambda (item) (car item)) pr-review-reaction-emojis))
+         (completion-extra-properties
+          (list :annotation-function
+                (lambda (n) (concat " " (alist-get n pr-review-reaction-emojis "" nil 'equal)))))
+         subject-id current-reaction-groups current-my-reactions)
+    (if (or (pr-review--description-section-p section)
+            (pr-review--review-section-p section)
+            (pr-review--comment-section-p section)
+            (pr-review--review-thread-item-section-p section))
+        (setq subject-id (oref section value)
+              current-reaction-groups (oref section reaction-groups))
+      (user-error "Current point is not reactable"))
+    (dolist (x current-reaction-groups)
+      (when (alist-get 'viewerHasReacted x)
+        (push (alist-get 'content x) current-my-reactions)))
+
+    (pr-review--update-reactions
+     subject-id
+     (completing-read-multiple "Reactions: " all-reaction-names nil t
+                               (concat (string-join current-my-reactions ",") ",")))
+    (pr-review-refresh)))
+
 (provide 'pr-review-action)
 ;;; pr-review-action.el ends here

pr-review-api.el

@@ -472,5 +472,22 @@ See `pr-review--get-repo-labels-1' for return value."
    `((input . ((labelableId . ,pr-node-id)
                (labelIds . ,(vconcat label-node-ids)))))))
 
+(defun pr-review--update-reactions (subject-id reactions)
+  "Update REACTIONS to SUBJECT-ID.
+REACTIONS is a list of reaction names.
+Those not in the list would be removed."
+  (let ((graphql (mapconcat
+                  (lambda (enum-item)
+                    (if (member (car enum-item) reactions)
+                        (format "_%s: addReaction(input: { content: %s, subjectId: \"%s\" }) {clientMutationId}"
+                                (car enum-item) (car enum-item) subject-id)
+                      (format "_%s: removeReaction(input: { content: %s, subjectId: \"%s\" }) {clientMutationId}"
+                              (car enum-item) (car enum-item) subject-id)))
+                  pr-review-reaction-emojis
+                  "\n")))
+    (pr-review--execute-graphql-raw
+     (concat "mutation { \n" graphql "\n}")
+     nil)))
+
 (provide 'pr-review-api)
 ;;; pr-review-api.el ends here

pr-review-common.el

@@ -149,12 +149,14 @@
 (defclass pr-review--review-section (magit-section)
   ((body :initform nil)
    (updatable :initform nil)
-   (databaseId :initform nil)))
+   (databaseId :initform nil)
+   (reaction-groups :initform nil)))
 
 (defclass pr-review--comment-section (magit-section)
   ((body :initform nil)
    (updatable :initform nil)
-   (databaseId :initform nil)))
+   (databaseId :initform nil)
+   (reaction-groups :initform nil)))
 
 (defclass pr-review--diff-section (magit-section) ())
 (defclass pr-review--check-section (magit-section) ())
@@ -167,15 +169,17 @@
 (defclass pr-review--review-thread-item-section (magit-section)
   ((body :initform nil)
    (updatable :initform nil)
-   (databaseId :initform nil)))
+   (databaseId :initform nil)
+   (reaction-groups :initform nil)))
 
 (defclass pr-review--root-section (magit-section)
   ((title :initform nil)
    (updatable :initform nil)))
 
 (defclass pr-review--description-section (magit-section)
   ((body :initform nil)
-   (updatable :initform nil)))
+   (updatable :initform nil)
+   (reaction-groups :initform nil)))
 
 (defclass pr-review--event-section (magit-section) ())
 
@@ -202,5 +206,17 @@ Set to nil to disable source language syntax highlighting."
   :type 'number
   :group 'pr-review)
 
+(defvar pr-review-reaction-emojis
+  '(("CONFUSED" . "😕")
+    ("EYES" . "👀")
+    ("HEART" . "❤️")
+    ("HOORAY" . "🎉")
+    ("LAUGH" . "😄")
+    ("ROCKET" . "🚀")
+    ("THUMBS_DOWN" . "👎")
+    ("THUMBS_UP" . "👍"))
+  "Alist of github reaction name to emoji unicode.
+See https://docs.github.com/en/graphql/reference/enums#reactioncontent")
+
 (provide 'pr-review-common)
 ;;; pr-review-common.el ends here

pr-review-render.el

@@ -40,18 +40,6 @@
   :type 'integer
   :group 'pr-review)
 
-(defvar pr-review-reaction-emojis
-  '(("CONFUSED" . "😕")
-    ("EYES" . "👀")
-    ("HEART" . "❤️")
-    ("HOORAY" . "🎉")
-    ("LAUGH" . "😄")
-    ("ROCKET" . "🚀")
-    ("THUMBS_DOWN" . "👎")
-    ("THUMBS_UP" . "👍"))
-  "Alist of github reaction name to emoji unicode.
-See https://docs.github.com/en/graphql/reference/enums#reactioncontent")
-
 (defun pr-review--format-timestamp (str)
   "Convert and format timestamp STR from json."
   (concat
@@ -177,7 +165,7 @@ INDENT is an optional number of extra spaces at the start of the line."
             (setq s (concat s "  ")))
           (setq s (concat
                    s
-                   (format "%s*%d"
+                   (format "%s%d"
                            (alist-get .content pr-review-reaction-emojis .content nil 'equal)
                            .reactors.totalCount)
                    (when .viewerHasReacted
@@ -442,6 +430,7 @@ It will be inserted at the beginning."
                 (oset item-section databaseId .databaseId)
                 (oset item-section updatable .viewerCanUpdate)
                 (oset item-section body .body)
+                (oset item-section reaction-groups .reactionGroups)
                 (magit-insert-heading
                   (make-string (* 2 pr-review-section-indent-width) ?\s)
                   (pr-review--propertize-username .author.login)
@@ -481,6 +470,7 @@ It will be inserted at the beginning."
           (oset section databaseId .databaseId)
           (oset section updatable .viewerCanUpdate)
           (oset section body .body)
+          (oset section reaction-groups .reactionGroups)
           (magit-insert-heading
             (propertize "Reviewed by " 'face 'magit-section-heading)
             (pr-review--propertize-username .author.login)
@@ -504,6 +494,7 @@ It will be inserted at the beginning."
       (oset section databaseId .databaseId)
       (oset section updatable .viewerCanUpdate)
       (oset section body .body)
+      (oset section reaction-groups .reactionGroups)
       (magit-insert-heading
         (propertize "Commented by " 'face 'magit-section-heading)
         (pr-review--propertize-username .author.login)
@@ -869,9 +860,10 @@ it can be displayed in a single line."
       (pr-review--insert-reviewers-info pr)
       (pr-review--insert-assignees-info pr)
       (insert "\n")
-      (magit-insert-section section (pr-review--description-section)
+      (magit-insert-section section (pr-review--description-section .id)
         (oset section body .body)
         (oset section updatable .viewerCanUpdate)
+        (oset section reaction-groups .reactionGroups)
         (magit-insert-heading "Description")
         (pr-review--insert-html .bodyHTML)
         (pr-review--maybe-insert-reactions .reactionGroups))

pr-review.el

@@ -52,6 +52,7 @@
     (define-key map (kbd "C-c C-o") #'pr-review-open-in-default-browser)
     (define-key map (kbd "C-c C-q") #'pr-review-request-reviews)
     (define-key map (kbd "C-c C-l") #'pr-review-set-labels)
+    (define-key map (kbd "C-c C-j") #'pr-review-update-reactions)
     map))
 
 (defvar pr-review--mode-map-setup-for-evil-done nil)