@@ -46,7 +46,7 @@ def __init__(self, web3: Web3, registry: Registry, address: str, abi: list, wall
4646
4747 def parse_get_completable_attestations (self , response : list ) -> list :
4848 metadata_urls = attestations_utils .parse_solidity_string_array (
49- response [2 ], response [3 ]) # TODO: check response[3] data type
49+ response [2 ], response [3 ])
5050
5151 return [{'block_number' : el [0 ], 'issuer' : el [1 ], 'metadata_url' : el [2 ]} for el in attestations_utils .zip3 (response [0 ], response [1 ], metadata_urls )]
5252
@@ -228,7 +228,6 @@ def get_non_compliant_issuers(self, identifier: str, account: str) -> list:
228228
229229 return [attest ['issuer' ] for attest in results if not attest ['is_valid' ]]
230230
231- # TODO: test how signature is reconstracting
232231 def complete (self , identifier : str , account : str , issuer : str , code : str ) -> str :
233232 """
234233 Completes an attestation with the corresponding code
@@ -262,7 +261,6 @@ def complete(self, identifier: str, account: str, issuer: str, code: str) -> str
262261
263262 return self .__wallet .send_transaction (func_call )
264263
265- # TODO: test how signature is reconstracting and signer address
266264 def find_matching_issuer (self , identifier : str , account : str , code : str , issuers : list ) -> str :
267265 """
268266 Given a list of issuers, finds the matching issuer for a given code
@@ -371,7 +369,6 @@ def select_issuers(self, identifier: str) -> str:
371369 func_call = self ._contract .functions .selectIssuers ()
372370 return self .__wallet .send_transaction (func_call )
373371
374- # TODO: test request to the service
375372 def reveal_phone_number_to_issuer (self , phone_number : str , account : str , issuer : str , service_url : str , pepper : str = None , sms_retriver_app_sig : str = None ) -> dict :
376373 body = {'account' : account ,
377374 'phoneNumber' : phone_number ,
@@ -412,7 +409,6 @@ def validate_attestation_code(self, identifier: str, account: str, issuer: str,
412409
413410 return result != self .null_address
414411
415- # TODO: test with real data and requests to the third patry services
416412 def get_attestation_service_status (self , validator : dict ) -> dict :
417413 """
418414 Gets the relevant attestation service status for a validator
0 commit comments