Fix settings menu interactivity

Author: blakegearin

src/github-custom-global-navigation.user.js

@@ -2145,9 +2145,14 @@
       newLiElement.setAttribute('id', liElementId);
 
       newLiElement.onclick = () => {
-        GMC.open();
+        const closeButton = document.querySelector(SELECTORS.sidebars.right.closeButton);
+        if (!closeButton) {
+          logError(`Selector '${SELECTORS.sidebars.right.closeButton}' not found`);
+        } else {
+          closeButton.click();
+        }
 
-        if (GMC.get('on_open') === 'close sidebar') HEADER.querySelector(SELECTORS.sidebars.right.closeButton)?.click();
+        GMC.open();
       };
 
       const textElement = newLiElement.querySelector('[data-component="ActionList.Item--DividerContainer"]');
@@ -5836,15 +5841,6 @@
         ],
         default: 'do nothing',
       },
-      on_open: {
-        label: 'On open',
-        type: 'select',
-        options: [
-          'do nothing',
-          'close sidebar',
-        ],
-        default: 'close sidebar',
-      },
       menu_item_title: {
         label: 'Menu item title',
         type: 'text',