need for an async resolvers.update

[djstein]

hey all. I'm trying to make a update_user mutation that verifies that the ID passed via the input is the same as the request user.

thankfully I found the node_id.aresolve_node function to get the user instance via the GlobalID. However on the resolvers.update this is a sync operation and it is unfortunate that it must be wrapped with sync_to_async

from asgiref.sync import sync_to_async
from django.contrib.auth import get_user_model
from strawberry.types import Info
from strawberry_django_plus import gql
from strawberry_django_plus.mutations import resolvers

from authentication.types import (
    User,
    UserInputPartialInput,
)

UserModel = get_user_model()

@gql.type
class Mutation:
    @gql.mutation
    async def update_user(self, info: Info, input: UserInputPartialInput) -> User:
        data = vars(input)
        node_id: gql.relay.GlobalID = data.pop("id")
        instance = await node_id.aresolve_node(info, ensure_type=UserModel)
        request_user = await info.context.request.auser()
        if instance != request_user:
            raise PermissionError("You can only modify objects you own.")

        return await sync_to_async(resolvers.update)(
            info, instance, resolvers.parse_input(info, data)
        )

[bellini666]

Hrm, we could create a resolvers.aupdate, which basically calls update wrapped in sync_to_async.

Another possibility here would be to use gql.django.mutation with a sync function. I will automatically wrap the whole resolver in sync_to_async to make it work with ASGI. e.g.

@gql.type
class Mutation:
    @gql.django.mutation
    def update_user(self, info: Info, input: UserInputPartialInput) -> User:
        data = vars(input)
        node_id: gql.relay.GlobalID = data.pop("id")
        instance = node_id.resolve_node(info, ensure_type=UserModel)
        request_user = info.context.request.user
        if instance != request_user:
            raise PermissionError("You can only modify objects you own.")

        return resolvers.update(
            info, instance, resolvers.parse_input(info, data)
        )

Note that gql.django.mutation by default will modify your return value to be User | OperationInfo, which captures some django default errors like ValidationError/PermissionDenied and return them as OperationInfo messages. You can pass handle_django_errors=False if you don't want that

Having said all of that, do you want to try to open a PR to add those async variants to the resolvers? It should be very simple!