Conversation
blegat
commented
Jan 6, 2026
src/MOI_Nonlinear_fork.jl
Outdated
| append!( | ||
| model.operators.multivariate_operators, | ||
| [:vect, :dot, :hcat, :vcat, :norm, :sum, :row], | ||
| ) |
Owner
Author
There was a problem hiding this comment.
We also need to modify
https://github.com/jump-dev/MathOptInterface.jl/blob/100eab2e669e73689e1dc214391d97c24402e35c/src/Nonlinear/operators.jl#L173
but we can't because the struct is not mutable...
We probably need to make our own model completely
* Add OperatorRegistry because immutable in MOI Nonlinear (and Int fields will need to be modified) * Add DEFAULT_MULTIVARIATE_OPERATORS to extend it from MOI Nonlinear * Add OrderedCollections that was used in Model
* Add OperatorRegistry because immutable in MOI Nonlinear (and Int fields will need to be modified) * Add DEFAULT_MULTIVARIATE_OPERATORS to extend it from MOI Nonlinear * Add OrderedCollections that was used in Model
blegat
commented
Jan 9, 2026
| MathOptInterface = "b8f27783-ece8-5eb3-8dc8-9495eed66fee" | ||
| SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf" | ||
| Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
| OrderedCollections = "bac558e1-5e72-5ebc-8fee-abe8a469f55d" No newline at end of file |
Owner
Author
There was a problem hiding this comment.
We don't need to add it to the tests, it's just a dependency of ArrayDiff
Because we need a slight change in OperatorRegistry. Implying need to redefine Model and Evaluator because using it.
And change args types to our newly defined OperatorRegistry, Model and Evaluator
To check
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 99.33% 94.45% -4.89%
==========================================
Files 10 14 +4
Lines 1663 2110 +447
==========================================
+ Hits 1652 1993 +341
- Misses 11 117 +106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
To match MOI.Nonlinear. Note all functions have been copy-pasted from MOI.Nonlinear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.