Commit 73daff1
Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (flutter#170905)" (flutter#170994)
<!-- start_original_pr_link -->
Reverts: flutter#170905
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: goderbauer
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Analyzer failure: `The argument type
'InputDecorationTheme' can't be assigned to the parameter type
'InputDecorationThemeData?'. •
packages/flutter/test/material/input_decorator_test.dart:2959:33 •
argument_type_not_assignable`
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: bleroux
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {justinmc}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
## Description
This PR fixes `InputDecoration.floatingLabelBehavior` logic to query
ambient InputDecorationTheme.floatingLabelBehavior, previously it was
ignored.
## Related Issue
Fixes [InputDecorationTheme and IconTheme isn't fully
inherited](flutter#71813)
Will help to complete flutter#168981
## Tests
Adds 1 test
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>1 parent 6ebb7cf commit 73daff1
File tree
2 files changed
+25
-38
lines changed- packages/flutter
- lib/src/material
- test/material
2 files changed
+25
-38
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1924 | 1924 | | |
1925 | 1925 | | |
1926 | 1926 | | |
1927 | | - | |
1928 | | - | |
| 1927 | + | |
| 1928 | + | |
| 1929 | + | |
| 1930 | + | |
| 1931 | + | |
| 1932 | + | |
1929 | 1933 | | |
1930 | 1934 | | |
1931 | 1935 | | |
| |||
1976 | 1980 | | |
1977 | 1981 | | |
1978 | 1982 | | |
1979 | | - | |
| 1983 | + | |
| 1984 | + | |
| 1985 | + | |
| 1986 | + | |
| 1987 | + | |
| 1988 | + | |
| 1989 | + | |
| 1990 | + | |
| 1991 | + | |
1980 | 1992 | | |
1981 | 1993 | | |
1982 | 1994 | | |
| |||
1991 | 2003 | | |
1992 | 2004 | | |
1993 | 2005 | | |
1994 | | - | |
1995 | | - | |
1996 | | - | |
1997 | | - | |
1998 | 2006 | | |
1999 | 2007 | | |
2000 | 2008 | | |
| |||
2026 | 2034 | | |
2027 | 2035 | | |
2028 | 2036 | | |
2029 | | - | |
2030 | | - | |
2031 | | - | |
2032 | | - | |
2033 | 2037 | | |
2034 | 2038 | | |
2035 | 2039 | | |
| |||
2041 | 2045 | | |
2042 | 2046 | | |
2043 | 2047 | | |
2044 | | - | |
| 2048 | + | |
2045 | 2049 | | |
2046 | 2050 | | |
2047 | 2051 | | |
| |||
2127 | 2131 | | |
2128 | 2132 | | |
2129 | 2133 | | |
2130 | | - | |
| 2134 | + | |
| 2135 | + | |
2131 | 2136 | | |
2132 | 2137 | | |
2133 | 2138 | | |
| |||
2352 | 2357 | | |
2353 | 2358 | | |
2354 | 2359 | | |
2355 | | - | |
| 2360 | + | |
| 2361 | + | |
| 2362 | + | |
| 2363 | + | |
2356 | 2364 | | |
2357 | 2365 | | |
2358 | 2366 | | |
| |||
2368 | 2376 | | |
2369 | 2377 | | |
2370 | 2378 | | |
2371 | | - | |
| 2379 | + | |
2372 | 2380 | | |
2373 | 2381 | | |
2374 | 2382 | | |
2375 | 2383 | | |
2376 | 2384 | | |
2377 | | - | |
| 2385 | + | |
2378 | 2386 | | |
2379 | 2387 | | |
2380 | 2388 | | |
| |||
2388 | 2396 | | |
2389 | 2397 | | |
2390 | 2398 | | |
2391 | | - | |
| 2399 | + | |
2392 | 2400 | | |
2393 | 2401 | | |
2394 | 2402 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2944 | 2944 | | |
2945 | 2945 | | |
2946 | 2946 | | |
2947 | | - | |
2948 | | - | |
2949 | 2947 | | |
2950 | 2948 | | |
2951 | 2949 | | |
2952 | 2950 | | |
2953 | 2951 | | |
2954 | | - | |
2955 | | - | |
2956 | | - | |
2957 | | - | |
2958 | | - | |
2959 | | - | |
2960 | | - | |
2961 | | - | |
2962 | | - | |
2963 | | - | |
2964 | | - | |
2965 | | - | |
2966 | | - | |
2967 | | - | |
2968 | | - | |
2969 | | - | |
2970 | | - | |
2971 | | - | |
2972 | | - | |
2973 | 2952 | | |
2974 | 2953 | | |
2975 | 2954 | | |
| |||
0 commit comments