MB-57888: Naming changes

Author: Likith101

index/scorch/optimize_knn.go

@@ -87,7 +87,7 @@ func (o *OptimizeVR) Finish() error {
 				for field, vrs := range o.vrs {
 					var vecIndex segment_api.VectorIndex
 					var err error
-					if info, ok := o.snapshot.updatedFields[field]; ok && (info.RemoveAll || info.Index) {
+					if info, ok := o.snapshot.updatedFields[field]; ok && (info.Deleted || info.Index) {
 						vecIndex, err = segment.InterpretVectorIndex("",
 							o.requiresFiltering, origSeg.deleted)
 					} else {

index/scorch/scorch.go

@@ -947,7 +947,7 @@ func (s *Scorch) updateBolt(fieldInfo map[string]index.UpdateFieldInfo, mappingB
 						for field, info := range fieldInfo {
 							if val, ok := updatedFields[field]; ok {
 								updatedFields[field] = index.UpdateFieldInfo{
-									RemoveAll: info.RemoveAll || val.RemoveAll,
+									Deleted:   info.Deleted || val.Deleted,
 									Store:     info.Store || val.Store,
 									DocValues: info.DocValues || val.DocValues,
 									Index:     info.Index || val.Index,

index/scorch/snapshot_index.go

@@ -473,7 +473,7 @@ func (is *IndexSnapshot) Document(id string) (rv index.Document, err error) {
 
 		// Skip fields that are supposed to have deleted store values
 		if info, ok := is.updatedFields[name]; ok &&
-			(info.RemoveAll || info.Store) {
+			(info.Deleted || info.Store) {
 			return true
 		}
 
@@ -622,7 +622,7 @@ func (is *IndexSnapshot) TermFieldReader(ctx context.Context, term []byte, field
 
 			// Skip fields that are supposed to have no indexing
 			if info, ok := is.updatedFields[field]; ok &&
-				(info.Index || info.RemoveAll) {
+				(info.Index || info.Deleted) {
 				dict, err = s.segment.Dictionary("")
 			} else {
 				dict, err = s.segment.Dictionary(field)
@@ -779,7 +779,7 @@ func (is *IndexSnapshot) documentVisitFieldTermsOnSegment(
 	var filteredFields []string
 	for _, field := range vFields {
 		if info, ok := is.updatedFields[field]; ok &&
-			(info.DocValues || info.RemoveAll) {
+			(info.DocValues || info.Deleted) {
 			continue
 		} else {
 			filteredFields = append(filteredFields, field)
@@ -1172,7 +1172,7 @@ func (is *IndexSnapshot) UpdateFieldsInfo(updatedFields map[string]*index.Update
 	} else {
 		for fieldName, info := range updatedFields {
 			if val, ok := is.updatedFields[fieldName]; ok {
-				val.RemoveAll = val.RemoveAll || info.RemoveAll
+				val.Deleted = val.Deleted || info.Deleted
 				val.Index = val.Index || info.Index
 				val.DocValues = val.DocValues || info.DocValues
 				val.Store = val.Store || info.Store

index/scorch/snapshot_segment.go

@@ -154,7 +154,7 @@ func (s *SegmentSnapshot) UpdateFieldsInfo(updatedFields map[string]*index.Updat
 	} else {
 		for fieldName, info := range updatedFields {
 			if val, ok := s.updatedFields[fieldName]; ok {
-				val.RemoveAll = val.RemoveAll || info.RemoveAll
+				val.Deleted = val.Deleted || info.Deleted
 				val.Index = val.Index || info.Index
 				val.DocValues = val.DocValues || info.DocValues
 				val.Store = val.Store || info.Store

index_update.go

@@ -101,10 +101,10 @@ func DeletedFields(ori, upd *mapping.IndexMappingImpl) (map[string]*index.Update
 	// Remove entries from the list with no changes between the
 	// original and the updated mapping
 	for name, info := range fieldInfo {
-		if !info.RemoveAll && !info.Index && !info.DocValues && !info.Store {
+		if !info.Deleted && !info.Index && !info.DocValues && !info.Store {
 			delete(fieldInfo, name)
 		}
-		if info.RemoveAll {
+		if info.Deleted {
 			if upd.IndexDynamic {
 				return nil, fmt.Errorf("Mapping cannot be removed when index dynamic is true")
 			}
@@ -322,7 +322,7 @@ func compareFieldMapping(original, updated *mapping.FieldMapping, defaultChanges
 
 	if updated == nil {
 		if original != nil && !original.IncludeInAll {
-			rv.RemoveAll = true
+			rv.Deleted = true
 			return rv, true, nil
 		} else if original == nil {
 			return nil, false, nil
@@ -406,7 +406,7 @@ func compareFieldMapping(original, updated *mapping.FieldMapping, defaultChanges
 		}
 	}
 
-	if rv.RemoveAll || rv.Index || rv.Store || rv.DocValues {
+	if rv.Deleted || rv.Index || rv.Store || rv.DocValues {
 		return rv, true, nil
 	}
 	return rv, false, nil
@@ -437,7 +437,7 @@ func validateFieldInfo(newInfo *index.UpdateFieldInfo, updated bool, fInfo map[s
 		}
 	}
 	if oldInfo, ok := fInfo[name]; ok {
-		if oldInfo.RemoveAll != newInfo.RemoveAll || oldInfo.Index != newInfo.Index ||
+		if oldInfo.Deleted != newInfo.Deleted || oldInfo.Index != newInfo.Index ||
 			oldInfo.DocValues != newInfo.DocValues || oldInfo.Store != newInfo.Store {
 			return fmt.Errorf("updated field impossible to verify because multiple mappings point to the same field name")
 		}

index_update_test.go

@@ -55,7 +55,7 @@ func TestCompareFieldMapping(t *testing.T) {
 				synonymSource:  false,
 			},
 			indexFieldInfo: &index.UpdateFieldInfo{
-				RemoveAll: true,
+				Deleted: true,
 			},
 			changed: true,
 			err:     false,
@@ -1913,7 +1913,7 @@ func TestDeletedFields(t *testing.T) {
 					DocValues: true,
 				},
 				"d": {
-					RemoveAll: true,
+					Deleted: true,
 				},
 			},
 			err: false,