Addressing review comments

Author: Likith101

index/scorch/scorch.go

@@ -955,9 +955,7 @@ func (s *Scorch) UpdateFields(fieldInfo map[string]*index.UpdateFieldInfo, mappi
 		return err
 	}
 	// Pass the update field info to all snapshots and segment bases
-	s.root.m.Lock()
 	s.root.UpdateFieldsInfo(fieldInfo)
-	s.root.m.Unlock()
 	return nil
 }
 

index/scorch/snapshot_index.go

@@ -1207,6 +1207,9 @@ func (is *IndexSnapshot) UpdateSynonymSearchCount(delta uint64) {
 
 // Update current snapshot updated field data as well as pass it on to all segments and segment bases
 func (is *IndexSnapshot) UpdateFieldsInfo(updatedFields map[string]*index.UpdateFieldInfo) {
+	is.m.Lock()
+	defer is.m.Unlock()
+
 	is.MergeUpdateFieldsInfo(updatedFields)
 
 	for _, segmentSnapshot := range is.segment {