Support RequestParam with Collection (multiple values)

Author: khannedy

blibli-backend-framework-api-client/src/main/java/com/blibli/oss/backend/apiclient/aop/ApiClientMethodInterceptor.java

@@ -287,7 +287,12 @@ private URI getUri(UriBuilder builder, String methodName, Object[] arguments) {
     builder.path(metadata.getPaths().get(methodName));
 
     metadata.getQueryParamPositions().get(methodName).forEach((paramName, position) -> {
-      builder.queryParam(paramName, arguments[position]);
+      if (arguments[position] instanceof Collection) {
+        Collection collection = (Collection) arguments[position];
+        builder.queryParam(paramName, collection);
+      } else {
+        builder.queryParam(paramName, arguments[position]);
+      }
     });
 
     Map<String, Object> uriVariables = new HashMap<>();

blibli-backend-framework-api-client/src/test/java/com/blibli/oss/backend/apiclient/SleuthApiClientTest.java

@@ -36,4 +36,18 @@ void testSleuth() {
       .jsonPath("$.firstName").isEqualTo("Eko")
       .jsonPath("$.lastName").isEqualTo("Khannedy");
   }
+
+  @Test
+  void testList() {
+    webTestClient.get()
+      .uri(uriBuilder -> uriBuilder
+        .path("/list")
+        .build())
+      .exchange()
+      .expectStatus().is2xxSuccessful()
+      .expectBody()
+      .jsonPath("$.value[0]").isEqualTo("Eko")
+      .jsonPath("$.value[1]").isEqualTo("Kurniawan")
+      .jsonPath("$.value[2]").isEqualTo("Khannedy");
+  }
 }

blibli-backend-framework-api-client/src/test/java/com/blibli/oss/backend/apiclient/client/SleuthApiClient.java

@@ -1,11 +1,14 @@
 package com.blibli.oss.backend.apiclient.client;
 
 import com.blibli.oss.backend.apiclient.annotation.ApiClient;
+import com.blibli.oss.backend.apiclient.client.model.GenericResponse;
 import org.springframework.http.MediaType;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RequestMethod;
+import org.springframework.web.bind.annotation.RequestParam;
 import reactor.core.publisher.Mono;
 
+import java.util.List;
 import java.util.Map;
 
 @ApiClient(
@@ -20,4 +23,10 @@ public interface SleuthApiClient {
   )
   Mono<Map<String, String>> second();
 
+  @RequestMapping(
+    value = "/names",
+    produces = MediaType.APPLICATION_JSON_VALUE
+  )
+  Mono<GenericResponse<List<String>>> names(@RequestParam("names") List<String> names);
+
 }

blibli-backend-framework-api-client/src/test/java/com/blibli/oss/backend/apiclient/controller/SleuthController.java

@@ -3,6 +3,7 @@
 import brave.Tracer;
 import brave.propagation.ExtraFieldPropagation;
 import com.blibli.oss.backend.apiclient.client.SleuthApiClient;
+import com.blibli.oss.backend.apiclient.client.model.GenericResponse;
 import com.blibli.oss.backend.sleuth.configuration.SleuthConfiguration;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.MediaType;
@@ -12,7 +13,9 @@
 import org.springframework.web.server.ServerWebExchange;
 import reactor.core.publisher.Mono;
 
+import java.util.Arrays;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 
 @RestController
@@ -48,4 +51,21 @@ public Mono<Map<String, String>> second(ServerWebExchange exchange) {
     return Mono.just(map);
   }
 
+  @GetMapping(
+    value = "/list",
+    produces = MediaType.APPLICATION_JSON_VALUE
+  )
+  public Mono<GenericResponse<List<String>>> list() {
+    return sleuthApiClient.names(Arrays.asList("Eko", "Kurniawan", "Khannedy"));
+  }
+
+  @GetMapping(
+    value = "/names",
+    produces = MediaType.APPLICATION_JSON_VALUE
+  )
+  public Mono<GenericResponse<List<String>>> names(@RequestParam("names") List<String> names) {
+    GenericResponse<List<String>> response = new GenericResponse<>(names);
+    return Mono.just(response);
+  }
+
 }