Skip to content

Adding query params able to be configured via properties #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding query params able to be configured via properties #42

wants to merge 2 commits into from

Conversation

@mehtakaran9
Copy link

@mehtakaran9 mehtakaran9 commented Aug 13, 2021

Right now, only headers can be configured via properties, static params can be supported with the following approach for clients.

@khannedy
Copy link
Member

khannedy commented Aug 16, 2021

hi @mehtakaran9 can you add unit test for this feature, like this :

https://github.com/bliblidotcom/blibli-backend-framework/blob/master/blibli-backend-framework-api-client/src/test/java/com/blibli/oss/backend/apiclient/DynamicClientTest.java

@mehtakaran9 mehtakaran9 mentioned this pull request Aug 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mehtakaran9 @khannedy