Visible Virtual Treeview causes multiple problems in other controls in Lazarus/Cocoa

[TommySlokky]

case1.zip

Here is a demo project which demonstrates multiple issues when having a visible virtual treeview on Lazarus Mac/Cocoa (using fpcupdeluxe "trunk" which includes newest virtual treeview)

Issue was reported here: https://bugs.freepascal.org/view.php?id=34002

And together with Lazarus developers narrowed it down to be an issue with virtual treeview and cocoa.

The attached demo project demonstrates:

1. Toolbuttons becoming invisible until clicked
2. TPageControl tabsheets misdrawn until clicked
3. TEdit looking very weird with black background until clicked
4. Some captions/labels etc. are drawn upside down some places

All only when the two virtual treeviews are set to visible in the project.

...

To see all issues simply

• run project
• doubleclick window title bar (minimizes to dock)
• open from mac dock.

[blikblum]

VirtualTreeView does not uses cocoa directly, just LCL and lclextensions. Probably some of the LCL API used by VirtualTreeView is not mature enough on cocoa. The way to go is to isolate the API that is broken and fix it. In early days i did this for win32, qt and gtk2 widgetsets. I fixed a lot of LCL / widgetset. Unfortunately i don't have a mac.

If you want to isolate code from lclextensions, compile with USE_DELPHICOMPAT directive disabled (VTConfig.inc)

[TommySlokky]

Thank you for your answer. I try see if i can find time to study LCL/widgetset implementations, Cocoa and connect the dots with Virtual Treeview. It is an extremely important control (to me at least), so kinda critical it is not working on Cocoa :(

[blikblum]

As a start i really suggest compiling with USE_DELPHICOMPAT directive enabled. This will ensure only LCL functions are called. It should work normally but slower

[TommySlokky]

I will try that now.

Meanwhile I I have tried two non-virtual-treeview demos using graphic routines that appears to work on Cocoa - a when least standalone:

1. https://forum.lazarus.freepascal.org/index.php/topic,36871.msg246309.html#msg246309 
   Called SpriteTest2.Zip and it uses copyrect, mask, union

2) https://forum.lazarus.freepascal.org/index.php/topic,36871.msg246790.html#msg246790 
Same thread, Mr.Madguy code listed uses intersect, fillrect, cliprect

[TommySlokky]

Offhand not possible to comment out the USE_DELPHICOMPAT define - it results in the following errors:

VirtualTree.pas

• SetBrushOrigin
  -- SetBrushOrgEx (Identifier not found)
• HandleMouseDown
  -- WM_LBUTTONDOWN (Identifier not found)

I did try comment out some other defines in VTConfig.inc - EnableAdvancedGraphics - but that did not make any difference.

...

Do you know what kind of graphic routines virtual treeview uses beyond those used in the two above demos? I am trying to create a demo application I can submit in my LCL cocoa bug report which reproduce the problem.

[blikblum]

Compiled now on linux and working fine. Should at least compile on mac

WM_LBUTTONDOWN (Identifier not found)

What version are you using? Do not use master, use lazarus-v4 or lazarus_v5 with lclextensions 0.6.1

There's no WM_LBUTTONDOWN

SetBrushOrgEx (Identifier not found)

This is protected by {$ifndef INCOMPLETE_WINAPI}. Also SetBrushOrigin was removed long time ago

[TommySlokky]

I am using the one that is included when using fpcupdeluxe/trunk / virtualtreeview-new (5.x)

Albeit currently lazarus now ships with virtual treeview package per default, just not installed - so fpcupdeluxe author states that is the newest version to use. (Not necessary to use fpcupdeluxe menu items for installing the virtualreeview-new (5x) package.)

You can see a problem report for lcl_extensions here:
https://bugs.freepascal.org/view.php?id=33973
http://forum.lazarus.freepascal.org/index.php/topic,42226.0.html

Where fpcupdeluxe developer tracked it down to: "Fpcupdeluxe uses online sources to install packages.However, these sources are fast changing and moving all the time.Now it seems that these vtv-sources are no longer updated due to the fact that they are included (again) with Lazarus ! So, just install the latest vtv by installing the vtv that comes with Lazarus."

(So that is what I have done)

...

But if I understand you correctly, I should probably install manually from the sources downloaded manually from here. I will do that and report back (!)

[blikblum]

Fpcupdeluxe uses online sources to install packages.However, these sources are fast changing and moving all the time

lclextensions did not changed from a long time

But if I understand you correctly, I should probably install manually from the sources downloaded manually from here. I will do that and report back (!)

Yes. You can also use git and fork the repo. Use v4 or v5 branches:

https://github.com/blikblum/VirtualTreeView-Lazarus/tree/lazarus-v4
https://github.com/blikblum/VirtualTreeView-Lazarus/tree/lazarus-v5

[TommySlokky]

This bug report still applies then:
https://bugs.freepascal.org/view.php?id=33973

delphicompat.pas(137,2) Fatal: Cannot open include file "uses.inc"

Looking in lclextensions-0/include you have subfolders for
-carbon
-generic
-gtk
-gtk2
-qt
-win32
(where each contains uses.inc)

But none for Cocoa

I suspect that is the reason and fix is simple. I will test later

[TommySlokky]

Well, not so easy, but the latest version of LazarusTrunk includes a version of lclextensions where Cocoa version of delphicompat.inc (etc.) has been added.

So it would seem Lazarus people have made several additions without adding them to:
https://github.com/blikblum/luipack/tree/master/lclextensions/include
?

[TommySlokky]

I uninstalled all old virtualtreeview... and fixed lclextensions

...

Then I downloaded from
https://github.com/blikblum/VirtualTreeView-Lazarus/tree/lazarus-v5
using "Download or clone"

Then go into VTConfig.ini and switch off USE_DELPHICOMPAT define

and I still get error

VirtualTrees (5282,3) Error: Identifier not found "SetBrushOrgEx"

and

VirtualTrees (22188,38) Error: Identifier not found "VM_LButtonDown"

...

I can send screenshots...

[blikblum]

Please send screenshots of the places that the compiler warns about missing identifier

[TommySlokky]

na

[blikblum]

You are using lazarus-master branch which is not completed yet.
Try these: https://github.com/blikblum/VirtualTreeView-Lazarus/releases

[TommySlokky]

Okay, so I on my Mac Lazarus Install:

• uninstalled old package
• downloaded and installed virtualtreeview-5-5.3-R1.zip
• comment off the define USE_DELPHICOMPAT

The same two issues but different line numbers. They are

VirtualTrees (5273,3) Error: Identifier not found "SetBrushOrgEx"
and
VirtualTrees (22179,38) Error: Identifier not found "VM_LButtonDown"

...

Just to confirm again I downloaded the file you suggest in Windows and opened in Notepad+ and navigated to the line numbers. I see them both there as well at the line numbers I report here.

...

And just to further confirm - I also tried download "source code (Zip)" https://github.com/blikblum/VirtualTreeView-Lazarus/archive/lazarus-5.5.3-R1.zip
just in case you meant I should download that - and again I see them both there same line numbers