refactor: testing code of workspace ops

Author: blindFS

crates/nu-lsp/src/diagnostics.rs

@@ -93,18 +93,15 @@ mod tests {
         script.push(filename);
         let script = path_to_uri(&script);
 
+        let mut notification = open_unchecked(&client_connection, script.clone());
         // For files that need fixing, open first then update
-        let notification = if let (Some(text), Some(range)) = (update_text, update_range) {
-            open_unchecked(&client_connection, script.clone());
-            update(
+        if let (Some(text), Some(range)) = (update_text, update_range) {
+            notification = update(
                 &client_connection,
                 script.clone(),
                 String::from(text),
                 Some(range),
-            )
-        } else {
-            // For files with no issues, just open
-            open_unchecked(&client_connection, script.clone())
+            );
         };
 
         assert_json_eq!(

crates/nu-lsp/src/hover.rs

@@ -189,7 +189,7 @@ impl LanguageServer {
             }
             Id::Value(t) => markdown_hover(format!("`{t}`")),
             Id::External(cmd) => {
-                fn fix_manpage_ascii_shenanigans(text: &str) -> Cow<str> {
+                fn fix_manpage_ascii_shenanigans(text: &str) -> Cow<'_, str> {
                     if cfg!(windows) {
                         Cow::Borrowed(text)
                     } else {

crates/nu-lsp/src/semantic_tokens.rs

@@ -128,9 +128,7 @@ mod tests {
         let (client_connection, _recv) = initialize_language_server(None, None);
 
         let mut script = fixtures();
-        script.push("lsp");
-        script.push("semantic_tokens");
-        script.push("internals.nu");
+        script.push("lsp/semantic_tokens/internals.nu");
         let script = path_to_uri(&script);
 
         open_unchecked(&client_connection, script.clone());

crates/nu-lsp/src/signature.rs

@@ -385,9 +385,7 @@ mod tests {
         let (client_connection, _recv) = initialize_language_server(config, None);
 
         let mut script = fixtures();
-        script.push("lsp");
-        script.push("hints");
-        script.push("signature.nu");
+        script.push("lsp/hints/signature.nu");
         let script = path_to_uri(&script);
 
         open_unchecked(&client_connection, script.clone());