Skip to content

Commit d6e6a90

Browse files
committed
fix(parser): namespace pollution of constants by use module_name
1 parent 0f8f3bc commit d6e6a90

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

crates/nu-protocol/src/module.rs

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ impl Module {
128128
} else {
129129
// Import pattern was just name without any members
130130
let mut decls = vec![];
131-
let mut const_vids = vec![];
132131
let mut const_rows = vec![];
133132
let mut errors = vec![];
134133

@@ -154,18 +153,14 @@ impl Module {
154153
decls.push((new_name, sub_decl_id));
155154
}
156155

157-
const_vids.extend(sub_results.constants);
158156
const_rows.extend(sub_results.constant_values);
159157
}
160158

161159
decls.extend(self.decls_with_head(&final_name));
162160

163161
for (name, var_id) in self.consts() {
164162
match working_set.get_constant(var_id) {
165-
Ok(const_val) => {
166-
const_vids.push((name.clone(), var_id));
167-
const_rows.push((name, const_val.clone()))
168-
}
163+
Ok(const_val) => const_rows.push((name, const_val.clone())),
169164
Err(err) => errors.push(err),
170165
}
171166
}
@@ -192,7 +187,7 @@ impl Module {
192187
ResolvedImportPattern::new(
193188
decls,
194189
vec![(final_name.clone(), self_id)],
195-
const_vids,
190+
vec![],
196191
constant_values,
197192
),
198193
errors,

0 commit comments

Comments
 (0)