cleanup

blindFS · blindFS · commit e55f2ebc506f · 2025-09-07T18:14:28.000+08:00
diff --git a/crates/nu-parser/src/parse_keywords.rs b/crates/nu-parser/src/parse_keywords.rs
@@ -581,7 +581,6 @@ fn parse_def_inner(
                 }
             }
 
-            let starting_error_count = working_set.parse_errors.len();
             let ParsedInternalCall {
                 call,
                 output,
@@ -592,10 +591,6 @@ fn parse_def_inner(
                 rest_spans,
                 decl_id,
             );
-            // This is to preserve the order of the errors so that
-            // the check errors below come first
-            let mut new_errors = working_set.parse_errors[starting_error_count..].to_vec();
-            working_set.parse_errors.truncate(starting_error_count);
 
             working_set.exit_scope();
 
@@ -620,8 +615,6 @@ fn parse_def_inner(
                 }
             }
 
-            working_set.parse_errors.append(&mut new_errors);
-
             if call_kind != CallKind::Valid {
                 return (
                     Expression::new(working_set, Expr::Call(call), call_span, output),

Original file line number	Diff line number	Diff line change
`@@ -581,7 +581,6 @@ fn parse_def_inner(`
`581`	`581`	`}`
`582`	`582`	`}`
`583`	`583`
`584`		`- let starting_error_count = working_set.parse_errors.len();`
`585`	`584`	`let ParsedInternalCall {`
`586`	`585`	`call,`
`587`	`586`	`output,`
`@@ -592,10 +591,6 @@ fn parse_def_inner(`
`592`	`591`	`rest_spans,`
`593`	`592`	`decl_id,`
`594`	`593`	`);`
`595`		`- // This is to preserve the order of the errors so that`
`596`		`- // the check errors below come first`
`597`		`- let mut new_errors = working_set.parse_errors[starting_error_count..].to_vec();`
`598`		`- working_set.parse_errors.truncate(starting_error_count);`
`599`	`594`
`600`	`595`	`working_set.exit_scope();`
`601`	`596`
`@@ -620,8 +615,6 @@ fn parse_def_inner(`
`620`	`615`	`}`
`621`	`616`	`}`
`622`	`617`
`623`		`- working_set.parse_errors.append(&mut new_errors);`
`624`		`-`
`625`	`618`	`if call_kind != CallKind::Valid {`
`626`	`619`	`return (`
`627`	`620`	`Expression::new(working_set, Expr::Call(call), call_span, output),`