Merge branch 'master' of github.com:mongodb/mongo-python-driver

Author: blink1073

bson/binary.py

@@ -432,7 +432,7 @@ def from_vector(
             raise NotImplementedError("%s not yet supported" % dtype)
 
         metadata = struct.pack("<sB", dtype.value, padding)
-        data = struct.pack(f"{len(vector)}{format_str}", *vector)
+        data = struct.pack(f"<{len(vector)}{format_str}", *vector)
         return cls(metadata + data, subtype=VECTOR_SUBTYPE)
 
     def as_vector(self) -> BinaryVector:
@@ -454,7 +454,7 @@ def as_vector(self) -> BinaryVector:
 
         if dtype == BinaryVectorDtype.INT8:
             dtype_format = "b"
-            format_string = f"{n_values}{dtype_format}"
+            format_string = f"<{n_values}{dtype_format}"
             vector = list(struct.unpack_from(format_string, self, position))
             return BinaryVector(vector, dtype, padding)
 
@@ -465,13 +465,16 @@ def as_vector(self) -> BinaryVector:
                 raise ValueError(
                     "Corrupt data. N bytes for a float32 vector must be a multiple of 4."
                 )
-            vector = list(struct.unpack_from(f"{n_values}f", self, position))
+            dtype_format = "f"
+            format_string = f"<{n_values}{dtype_format}"
+            vector = list(struct.unpack_from(format_string, self, position))
             return BinaryVector(vector, dtype, padding)
 
         elif dtype == BinaryVectorDtype.PACKED_BIT:
             # data packed as uint8
             dtype_format = "B"
-            unpacked_uint8s = list(struct.unpack_from(f"{n_values}{dtype_format}", self, position))
+            format_string = f"<{n_values}{dtype_format}"
+            unpacked_uint8s = list(struct.unpack_from(format_string, self, position))
             return BinaryVector(unpacked_uint8s, dtype, padding)
 
         else:

hatch.toml

@@ -43,7 +43,7 @@ features = ["test"]
 test = "pytest -v --durations=5 --maxfail=10 {args}"
 test-eg = "bash ./.evergreen/run-tests.sh {args}"
 test-async = "pytest -v --durations=5 --maxfail=10 -m default_async {args}"
-test-mockupdb = ["pip install -U git+https://github.com/ajdavis/mongo-mockup-db@master", "test -m mockupdb"]
+test-mockupdb = ["pip install -U git+https://github.com/mongodb-labs/mongo-mockup-db@master", "test -m mockupdb"]
 
 [envs.encryption]
 skip-install = true

pymongo/results.py

@@ -171,9 +171,12 @@ def upserted_id(self) -> Any:
 
     @property
     def did_upsert(self) -> bool:
-        """Whether or not an upsert took place."""
+        """Whether an upsert took place.
+
+        .. versionadded:: 4.9
+        """
         assert self.__raw_result is not None
-        return len(self.__raw_result.get("upserted", {})) > 0
+        return "upserted" in self.__raw_result
 
 
 class DeleteResult(_WriteResult):

test/asynchronous/test_client_bulk_write.py

@@ -550,6 +550,46 @@ async def test_returns_error_if_auto_encryption_configured(self):
             "bulk_write does not currently support automatic encryption", context.exception._message
         )
 
+    @async_client_context.require_version_min(8, 0, 0, -24)
+    @async_client_context.require_no_serverless
+    async def test_upserted_result(self):
+        client = await self.async_rs_or_single_client()
+
+        collection = client.db["coll"]
+        self.addAsyncCleanup(collection.drop)
+        await collection.drop()
+
+        models = []
+        models.append(
+            UpdateOne(
+                namespace="db.coll",
+                filter={"_id": "a"},
+                update={"$set": {"x": 1}},
+                upsert=True,
+            )
+        )
+        models.append(
+            UpdateOne(
+                namespace="db.coll",
+                filter={"_id": None},
+                update={"$set": {"x": 1}},
+                upsert=True,
+            )
+        )
+        models.append(
+            UpdateOne(
+                namespace="db.coll",
+                filter={"_id": None},
+                update={"$set": {"x": 1}},
+            )
+        )
+        result = await client.bulk_write(models=models, verbose_results=True)
+
+        self.assertEqual(result.upserted_count, 2)
+        self.assertEqual(result.update_results[0].did_upsert, True)
+        self.assertEqual(result.update_results[1].did_upsert, True)
+        self.assertEqual(result.update_results[2].did_upsert, False)
+
 
 # https://github.com/mongodb/specifications/blob/master/source/client-side-operations-timeout/tests/README.md#11-multi-batch-bulkwrites
 class TestClientBulkWriteCSOT(AsyncIntegrationTest):

test/asynchronous/test_collection.py

@@ -1444,6 +1444,19 @@ async def test_update_one(self):
         self.assertRaises(InvalidOperation, lambda: result.upserted_id)
         self.assertFalse(result.acknowledged)
 
+    async def test_update_result(self):
+        db = self.db
+        await db.drop_collection("test")
+
+        result = await db.test.update_one({"x": 0}, {"$inc": {"x": 1}}, upsert=True)
+        self.assertEqual(result.did_upsert, True)
+
+        result = await db.test.update_one({"_id": None, "x": 0}, {"$inc": {"x": 1}}, upsert=True)
+        self.assertEqual(result.did_upsert, True)
+
+        result = await db.test.update_one({"_id": None}, {"$inc": {"x": 1}})
+        self.assertEqual(result.did_upsert, False)
+
     async def test_update_many(self):
         db = self.db
         await db.drop_collection("test")

test/mockupdb/test_handshake.py

@@ -26,7 +26,7 @@
 
 
 from bson.objectid import ObjectId
-from pymongo import MongoClient
+from pymongo import MongoClient, has_c
 from pymongo import version as pymongo_version
 from pymongo.errors import OperationFailure
 from pymongo.server_api import ServerApi, ServerApiVersion
@@ -39,7 +39,11 @@ def _check_handshake_data(request):
     data = request["client"]
 
     assert data["application"] == {"name": "my app"}
-    assert data["driver"] == {"name": "PyMongo", "version": pymongo_version}
+    if has_c():
+        name = "PyMongo|c"
+    else:
+        name = "PyMongo"
+    assert data["driver"] == {"name": name, "version": pymongo_version}
 
     # Keep it simple, just check these fields exist.
     assert "os" in data

test/test_client_bulk_write.py

@@ -550,6 +550,46 @@ def test_returns_error_if_auto_encryption_configured(self):
             "bulk_write does not currently support automatic encryption", context.exception._message
         )
 
+    @client_context.require_version_min(8, 0, 0, -24)
+    @client_context.require_no_serverless
+    def test_upserted_result(self):
+        client = self.rs_or_single_client()
+
+        collection = client.db["coll"]
+        self.addCleanup(collection.drop)
+        collection.drop()
+
+        models = []
+        models.append(
+            UpdateOne(
+                namespace="db.coll",
+                filter={"_id": "a"},
+                update={"$set": {"x": 1}},
+                upsert=True,
+            )
+        )
+        models.append(
+            UpdateOne(
+                namespace="db.coll",
+                filter={"_id": None},
+                update={"$set": {"x": 1}},
+                upsert=True,
+            )
+        )
+        models.append(
+            UpdateOne(
+                namespace="db.coll",
+                filter={"_id": None},
+                update={"$set": {"x": 1}},
+            )
+        )
+        result = client.bulk_write(models=models, verbose_results=True)
+
+        self.assertEqual(result.upserted_count, 2)
+        self.assertEqual(result.update_results[0].did_upsert, True)
+        self.assertEqual(result.update_results[1].did_upsert, True)
+        self.assertEqual(result.update_results[2].did_upsert, False)
+
 
 # https://github.com/mongodb/specifications/blob/master/source/client-side-operations-timeout/tests/README.md#11-multi-batch-bulkwrites
 class TestClientBulkWriteCSOT(IntegrationTest):

test/test_collection.py

@@ -1429,6 +1429,19 @@ def test_update_one(self):
         self.assertRaises(InvalidOperation, lambda: result.upserted_id)
         self.assertFalse(result.acknowledged)
 
+    def test_update_result(self):
+        db = self.db
+        db.drop_collection("test")
+
+        result = db.test.update_one({"x": 0}, {"$inc": {"x": 1}}, upsert=True)
+        self.assertEqual(result.did_upsert, True)
+
+        result = db.test.update_one({"_id": None, "x": 0}, {"$inc": {"x": 1}}, upsert=True)
+        self.assertEqual(result.did_upsert, True)
+
+        result = db.test.update_one({"_id": None}, {"$inc": {"x": 1}})
+        self.assertEqual(result.did_upsert, False)
+
     def test_update_many(self):
         db = self.db
         db.drop_collection("test")

test/test_results.py

@@ -122,6 +122,28 @@ def test_update_result(self):
         self.assertEqual(raw_result["n"], result.matched_count)
         self.assertEqual(raw_result["nModified"], result.modified_count)
         self.assertEqual(raw_result["upserted"], result.upserted_id)
+        self.assertEqual(result.did_upsert, True)
+
+        raw_result_2 = {
+            "n": 1,
+            "nModified": 1,
+            "upserted": [
+                {"index": 5, "_id": 1},
+            ],
+        }
+        self.repr_test(UpdateResult, raw_result_2)
+
+        result = UpdateResult(raw_result_2, True)
+        self.assertEqual(result.did_upsert, True)
+
+        raw_result_3 = {
+            "n": 1,
+            "nModified": 1,
+        }
+        self.repr_test(UpdateResult, raw_result_3)
+
+        result = UpdateResult(raw_result_3, True)
+        self.assertEqual(result.did_upsert, False)
 
         result = UpdateResult(raw_result, False)
         self.assertEqual(raw_result, result.raw_result)