PYTHON-4480 Deprecate create=True for Collection (mongodb#1659)

Author: NoahStapp

pymongo/asynchronous/collection.py

@@ -15,6 +15,7 @@
 """Collection level utilities for Mongo."""
 from __future__ import annotations
 
+import warnings
 from collections import abc
 from typing import (
     TYPE_CHECKING,
@@ -248,6 +249,11 @@ def __init__(
 
         if create or kwargs:
             if _IS_SYNC:
+                warnings.warn(
+                    "The `create` and `kwargs` arguments to Collection are deprecated and will be removed in PyMongo 5.0",
+                    DeprecationWarning,
+                    stacklevel=2,
+                )
                 self._create(kwargs, session)  # type: ignore[unused-coroutine]
             else:
                 raise ValueError(

pymongo/synchronous/collection.py

@@ -15,6 +15,7 @@
 """Collection level utilities for Mongo."""
 from __future__ import annotations
 
+import warnings
 from collections import abc
 from typing import (
     TYPE_CHECKING,
@@ -251,6 +252,11 @@ def __init__(
 
         if create or kwargs:
             if _IS_SYNC:
+                warnings.warn(
+                    "The `create` and `kwargs` arguments to Collection are deprecated and will be removed in PyMongo 5.0",
+                    DeprecationWarning,
+                    stacklevel=2,
+                )
                 self._create(kwargs, session)  # type: ignore[unused-coroutine]
             else:
                 raise ValueError("Collection does not support the `create` or `kwargs` arguments.")

test/test_collection.py

@@ -198,7 +198,11 @@ def test_create(self):
             "create create_test_no_wc collection",
         )
         db.create_test_no_wc.drop()
-        Collection(db, name="create_test_no_wc", create=True)
+        with self.assertWarns(
+            DeprecationWarning,
+            msg="The `create` and `kwargs` arguments to Collection are deprecated and will be removed in PyMongo 5.0",
+        ):
+            Collection(db, name="create_test_no_wc", create=True)
         wait_until(
             lambda: "create_test_no_wc" in db.list_collection_names(),
             "create create_test_no_wc collection",