fix: clarify link naming

Author: jeremydw

example/.github/workflows/fileset-upload.yml

@@ -44,9 +44,9 @@ jobs:
           -b ${GITHUB_REF#refs/heads/} \
           -o upload.json \
           build
-        echo "::set-output name=build-link::$(jq -r .urls.stagingSha upload.json)"
-        echo "::set-output name=dashboard-link::$(jq -r .urls.ui upload.json)"
-        echo "::set-output name=staging-link::$(jq -r .urls.stagingBranch upload.json)"
+        echo "::set-output name=build-link::$(jq -r .links.buildLink upload.json)"
+        echo "::set-output name=dashboard-link::$(jq -r .links.dashboardLink upload.json)"
+        echo "::set-output name=staging-link::$(jq -r .links.stagingLink upload.json)"
     - name: Comment
       uses: peter-evans/commit-comment@v1
       with:

src/commands/upload.ts

@@ -128,8 +128,8 @@ export class UploadCommand {
         manifestObj.commit.author.email
       }> ${manifestObj.commit.message.split('Change-Id')[0].trim()}`
     );
-    console.log('Dashboard:'.blue + ` ${manifestObj.urls.ui}`);
-    console.log('    Build:'.blue + ` ${manifestObj.urls.stagingSha}`);
-    console.log('  Staging:'.green + ` ${manifestObj.urls.stagingBranch}`);
+    console.log('Dashboard:'.blue + ` ${manifestObj.links.dashboardLink}`);
+    console.log('    Build:'.blue + ` ${manifestObj.links.buildLink}`);
+    console.log('  Staging:'.green + ` ${manifestObj.links.stagingLink}`);
   }
 }

src/manifest.ts

@@ -44,10 +44,10 @@ export interface Commit {
   author: GitAuthor;
 }
 
-export interface ManifestUrls {
-  stagingBranch: string;
-  stagingSha: string;
-  ui: string;
+export interface ManifestLinks {
+  stagingLink: string;
+  buildLink: string;
+  dashboardLink: string;
 }
 
 export interface SerializedManifest {
@@ -156,29 +156,29 @@ export class Manifest {
 
   toOutputJSON() {
     return {
-      urls: this.urls,
+      links: this.links,
       files: this.files,
       commit: this.commit,
     };
   }
 
-  get urls(): ManifestUrls {
+  get links(): ManifestLinks {
     // TODO: Allow customizing the staging URL using `fileset.yaml` configuration.
     const hostnameSuffix = `fileset-dot-${this.googleCloudProject}.appspot.com`;
-    const stagingShaUrl =
+    const buildLink =
       this.site === 'default'
         ? `https://${this.shortSha}-dot-${hostnameSuffix}`
         : `https://${this.site}-${this.shortSha}-dot-${hostnameSuffix}`;
     const branchToken = branchToHostnameToken(this.branch);
-    const stagingBranchUrl =
+    const stagingLink =
       this.site === 'default'
         ? `https://${branchToken}-dot-${hostnameSuffix}`
         : `https://${this.site}-${branchToken}-dot-${hostnameSuffix}`;
-    const uiUrl = `https://${hostnameSuffix}/fileset/sites/${this.site}/${this.shortSha}`;
+    const dashboardLink = `https://${hostnameSuffix}/fileset/sites/${this.site}/${this.shortSha}`;
     return {
-      stagingBranch: stagingBranchUrl,
-      stagingSha: stagingShaUrl,
-      ui: uiUrl,
+      stagingLink: stagingLink,
+      buildLink: buildLink,
+      dashboardLink: dashboardLink,
     };
   }
 }