fix: ignore getStaticPaths() for routes with no url params

Author: stevenle

packages/root/src/render/router.ts

@@ -109,7 +109,8 @@ export class Router {
 
     const urlPaths: Array<{urlPath: string; params: Record<string, string>}> =
       [];
-    if (routeModule.getStaticPaths) {
+    const pathHasParams = testPathHasParams(urlPathFormat);
+    if (pathHasParams && routeModule.getStaticPaths) {
       const staticPaths = await routeModule.getStaticPaths({
         rootConfig: this.rootConfig,
       });
@@ -120,9 +121,9 @@ export class Router {
               urlPathFormat,
               pathParams.params || {}
             );
-            if (pathContainsPlaceholders(urlPath)) {
+            if (testPathHasParams(urlPath)) {
               console.warn(
-                `path contains placeholders: ${urlPathFormat}, double check getStaticPaths() and ensure all params are returned. more info: https://rootjs.dev/guide/routes#getStaticPaths`
+                `path contains params: ${urlPathFormat}, double check getStaticPaths() and ensure all params are returned. more info: https://rootjs.dev/guide/routes#getStaticPaths`
               );
             } else {
               urlPaths.push({
@@ -135,22 +136,22 @@ export class Router {
       }
     } else if (
       routeModule.getStaticProps &&
-      !pathContainsPlaceholders(urlPathFormat)
+      !pathHasParams
     ) {
       urlPaths.push({urlPath: normalizeUrlPath(urlPathFormat), params: {}});
     } else if (
       !routeModule.handle &&
-      !pathContainsPlaceholders(urlPathFormat)
+      !pathHasParams
     ) {
       urlPaths.push({urlPath: normalizeUrlPath(urlPathFormat), params: {}});
     } else if (
-      pathContainsPlaceholders(urlPathFormat) &&
+      pathHasParams &&
       !routeModule.handle &&
       !routeModule.getStaticPaths
     ) {
       console.warn(
         [
-          `warning: path contains placeholders: ${urlPathFormat}.`,
+          `warning: path contains params: ${urlPathFormat}.`,
           `define either ssg getStaticPaths() or ssr handle() for route: ${route.src}.`,
           'more info: https://rootjs.dev/guide/routes',
         ].join('\n')
@@ -207,7 +208,7 @@ export function normalizeUrlPath(
   return urlPath;
 }
 
-function pathContainsPlaceholders(urlPath: string) {
+function testPathHasParams(urlPath: string) {
   const segments = urlPath.split('/');
   return segments.some((segment) => {
     return segment.startsWith('[') && segment.endsWith(']');