fix: update golangci-lint and clean up error messages (#394)

Signed-off-by: Chris Gianelloni <[email protected]>

Author: wolf31o2

.github/workflows/golangci-lint.yml

@@ -9,7 +9,6 @@ on:
 
 permissions:
   contents: read
-  pull-requests: read
 
 jobs:
   golangci:
@@ -21,6 +20,4 @@ jobs:
         with:
           go-version: 1.23.x
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
-        with:
-          only-new-issues: ${{ github.event_name == 'pull_request' && 'true' || 'false' }}
+        uses: golangci/golangci-lint-action@v7

.golangci.yml

@@ -1,32 +1,71 @@
-issues:
-  exclude-dirs:
-    - docs
-  max-issues-per-linter: 0
-  max-same-issues: 0
+version: "2"
+run:
+  issues-exit-code: 1
+  tests: false
 linters:
-  disable:
-    - depguard
   enable:
-    - errcheck
-    - gosimple
-    - govet
-    - ineffassign
-    - staticcheck
-    - unused
-    # Defaults above ours below
+    - asasalint
+    - asciicheck
+    - bidichk
+    - bodyclose
+    - contextcheck
     - copyloopvar
+    - durationcheck
+    - errchkjson
+    - errorlint
+    - exhaustive
+    - fatcontext
+    - gocheckcompilerdirectives
+    - gochecksumtype
+    - gomodguard
+    - gosec
+    - gosmopolitan
+    - loggercheck
+    - makezero
+    - musttag
+    - nilerr
+    - nilnesserr
+    - noctx
+    - perfsprint
+    - prealloc
+    - protogetter
+    - reassign
+    - recvcheck
+    - rowserrcheck
+    - spancheck
+    - sqlclosecheck
+    - testifylint
+    - unparam
     - usestdlibvars
     - whitespace
-  presets:
-    - bugs
-    - format
-    - import
-    - performance
-    - unused
-#linters-settings:
-#  errcheck:
-#    check-type-assertions: true
-run:
-  issues-exit-code: 1
-  tests: false
-  timeout: 10m
+    - zerologlint
+  disable:
+    - depguard
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - docs
+      - third_party$
+      - builtin$
+      - examples$
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0
+formatters:
+  enable:
+    - gci
+    - gofmt
+    - gofumpt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - docs
+      - third_party$
+      - builtin$
+      - examples$

input/chainsync/chainsync.go

@@ -514,7 +514,7 @@ func resolveTransactionInputs(
 			)
 			if err != nil {
 				return nil, fmt.Errorf(
-					"Error fetching matches for input TxId: %s, Index: %d. Error: %w\n",
+					"error fetching matches for input TxId: %s, Index: %d. Error: %w",
 					txId,
 					txIndex,
 					err,
@@ -523,14 +523,14 @@ func resolveTransactionInputs(
 
 			if len(matches) == 0 {
 				slog.Info(
-					"No matches found for input TxId: %s, Index: %d, could be due to Kupo not in sync\n",
+					"no matches found for input TxId: %s, Index: %d, could be due to Kupo not in sync",
 					txId,
 					txIndex,
 				)
 			} else {
-				slog.Debug(fmt.Sprintf("Found matches %d for input TxId: %s, Index: %d\n", len(matches), txId, txIndex))
+				slog.Debug(fmt.Sprintf("found matches %d for input TxId: %s, Index: %d", len(matches), txId, txIndex))
 				for _, match := range matches {
-					slog.Debug(fmt.Sprintf("Match: %#v\n", match))
+					slog.Debug(fmt.Sprintf("Match: %#v", match))
 					transactionOutput, err := NewResolvedTransactionOutput(match)
 					if err != nil {
 						return nil, err