chore: golangci-lint configuration (#360)

wolf31o2 · web-flow · commit a4ed2116046d · 2025-02-22T07:55:35.000-05:00
Signed-off-by: Chris Gianelloni &lt;wolf31o2@blinklabs.io&gt;
diff --git a/.golangci.yml b/.golangci.yml
@@ -0,0 +1,18 @@
+issues:
+  exclude-dirs:
+    - docs
+  max-issues-per-linter: 0
+  max-same-issues: 0
+linters:
+  enable:
+    - errcheck
+    - gosec
+    - gosimple
+    - govet
+    - ineffassign
+    - staticcheck
+    - unused
+run:
+  issues-exit-code: 1
+  tests: false
+  timeout: 10m
diff --git a/docs/docs.go b/docs/docs.go
diff --git a/internal/api/api.go b/internal/api/api.go
@@ -77,10 +77,28 @@ func Start(cfg *config.Config) error {
 				return
 			}
 		}
-		accessLogger.Info("request received", "method", c.Request.Method, "path", c.Request.URL.Path, "remote_addr", c.ClientIP())
+		accessLogger.Info(
+			"request received",
+			"method",
+			c.Request.Method,
+			"path",
+			c.Request.URL.Path,
+			"remote_addr",
+			c.ClientIP(),
+		)
 		c.Next()
 		statusCode := c.Writer.Status()
-		accessLogger.Info("response sent", "status", statusCode, "method", c.Request.Method, "path", c.Request.URL.Path, "remote_addr", c.ClientIP())
+		accessLogger.Info(
+			"response sent",
+			"status",
+			statusCode,
+			"method",
+			c.Request.Method,
+			"path",
+			c.Request.URL.Path,
+			"remote_addr",
+			c.ClientIP(),
+		)
 	}
 	router.Use(accessMiddleware)
 
diff --git a/internal/node/chainsync.go b/internal/node/chainsync.go
@@ -1,4 +1,4 @@
-// Copyright 2024 Blink Labs Software
+// Copyright 2025 Blink Labs Software
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -29,6 +29,7 @@ import (
 
 func buildChainSyncConfig(connCfg ConnectionConfig) chainsync.Config {
 	cfg := config.GetConfig()
+	// #nosec G115
 	return chainsync.NewConfig(
 		chainsync.WithBlockTimeout(
 			time.Duration(cfg.Node.QueryTimeout)*time.Second,
@@ -102,6 +103,7 @@ func chainSyncRollForwardHandler(
 				txEvt := event.New(
 					"chainsync.transaction",
 					time.Now(),
+					// #nosec G115
 					input_chainsync.NewTransactionContext(v, transaction, uint32(t), cfg.Node.NetworkMagic),
 					input_chainsync.NewTransactionEvent(v, transaction, true, nil),
 				)
diff --git a/internal/node/localstatequery.go b/internal/node/localstatequery.go
@@ -1,4 +1,4 @@
-// Copyright 2024 Blink Labs Software
+// Copyright 2025 Blink Labs Software
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -24,6 +24,7 @@ import (
 
 func buildLocalStateQueryConfig() localstatequery.Config {
 	cfg := config.GetConfig()
+	// #nosec G115
 	return localstatequery.NewConfig(
 		localstatequery.WithAcquireTimeout(
 			time.Duration(cfg.Node.Timeout)*time.Second,
diff --git a/internal/node/localtxmonitor.go b/internal/node/localtxmonitor.go
@@ -1,4 +1,4 @@
-// Copyright 2024 Blink Labs Software
+// Copyright 2025 Blink Labs Software
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -24,6 +24,7 @@ import (
 
 func buildLocalTxMonitorConfig() localtxmonitor.Config {
 	cfg := config.GetConfig()
+	// #nosec G115
 	return localtxmonitor.NewConfig(
 		localtxmonitor.WithAcquireTimeout(
 			time.Duration(cfg.Node.Timeout)*time.Second,
diff --git a/internal/node/localtxsubmission.go b/internal/node/localtxsubmission.go
@@ -1,4 +1,4 @@
-// Copyright 2024 Blink Labs Software
+// Copyright 2025 Blink Labs Software
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -24,6 +24,7 @@ import (
 
 func buildLocalTxSubmissionConfig() localtxsubmission.Config {
 	cfg := config.GetConfig()
+	// #nosec G115
 	return localtxsubmission.NewConfig(
 		localtxsubmission.WithTimeout(
 			time.Duration(cfg.Node.QueryTimeout) * time.Second,
diff --git a/internal/utxorpc/query.go b/internal/utxorpc/query.go
@@ -139,6 +139,7 @@ func (s *queryServiceServer) ReadUtxos(
 			aud.TxoRef = txo
 			txHash := hex.EncodeToString(txo.Hash)
 			if utxoId.Hash.String() == txHash &&
+				// #nosec G115
 				uint32(utxoId.Idx) == txo.Index {
 				aud.NativeBytes = utxo.Cbor()
 				audc.Cardano = utxo.Utxorpc()
@@ -272,7 +273,7 @@ func (s *queryServiceServer) SearchUtxos(
 		var audc query.AnyUtxoData_Cardano
 		aud.TxoRef = &query.TxoRef{
 			Hash:  utxoId.Hash.Bytes(),
-			Index: uint32(utxoId.Idx),
+			Index: uint32(utxoId.Idx), // #nosec G115
 		}
 		aud.NativeBytes = utxo.Cbor()
 		audc.Cardano = utxo.Utxorpc()
diff --git a/internal/utxorpc/submit.go b/internal/utxorpc/submit.go
@@ -80,7 +80,7 @@ func (s *submitServiceServer) SubmitTx(
 		}
 		// Submit the transaction
 		err = oConn.LocalTxSubmission().Client.SubmitTx(
-			uint16(txType),
+			uint16(txType), // #nosec G115
 			txRawBytes,
 		)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ func (s *submitServiceServer) SubmitTx(`
`80`	`80`	`}`
`81`	`81`	`// Submit the transaction`
`82`	`82`	`err = oConn.LocalTxSubmission().Client.SubmitTx(`
`83`		`- uint16(txType),`
	`83`	`+ uint16(txType), // #nosec G115`
`84`	`84`	`txRawBytes,`
`85`	`85`	`)`
`86`	`86`	`if err != nil {`