chore(golangci-lint): enable format, import, and unused presets; disable depguard

Signed-off-by: Chris Gianelloni <[email protected]>

Author: wolf31o2

.golangci.yml

@@ -4,6 +4,8 @@ issues:
   max-issues-per-linter: 0
   max-same-issues: 0
 linters:
+  disable:
+    - depguard
   enable:
     - errcheck
     - gosimple
@@ -12,9 +14,15 @@ linters:
     - staticcheck
     - unused
     # Defaults above ours below
+    - copyloopvar
+    - usestdlibvars
+    - whitespace
   presets:
     - bugs
+    - format
+    - import
     - performance
+    - unused
 #linters-settings:
 #  errcheck:
 #    check-type-assertions: true

cmd/cardano-node-api/main.go

@@ -19,20 +19,18 @@ import (
 	"fmt"
 	"log/slog"
 	"net/http"
-	"os"
-	"time"
-
 	// #nosec G108
 	_ "net/http/pprof"
-
-	"go.uber.org/automaxprocs/maxprocs"
+	"os"
+	"time"
 
 	"github.com/blinklabs-io/cardano-node-api/internal/api"
 	"github.com/blinklabs-io/cardano-node-api/internal/config"
 	"github.com/blinklabs-io/cardano-node-api/internal/logging"
 	"github.com/blinklabs-io/cardano-node-api/internal/node"
 	"github.com/blinklabs-io/cardano-node-api/internal/utxorpc"
 	"github.com/blinklabs-io/cardano-node-api/internal/version"
+	"go.uber.org/automaxprocs/maxprocs"
 )
 
 var cmdlineFlags struct {

internal/api/api.go

@@ -18,15 +18,13 @@ import (
 	"fmt"
 	"os"
 
+	_ "github.com/blinklabs-io/cardano-node-api/docs" // docs is generated by Swag CLI
 	"github.com/blinklabs-io/cardano-node-api/internal/config"
 	"github.com/blinklabs-io/cardano-node-api/internal/logging"
-
 	"github.com/gin-gonic/gin"
 	"github.com/penglongli/gin-metrics/ginmetrics"
-
-	_ "github.com/blinklabs-io/cardano-node-api/docs" // docs is generated by Swag CLI
-	swaggerFiles "github.com/swaggo/files"            // swagger embed files
-	ginSwagger "github.com/swaggo/gin-swagger"        // gin-swagger middleware
+	swaggerFiles "github.com/swaggo/files"     // swagger embed files
+	ginSwagger "github.com/swaggo/gin-swagger" // gin-swagger middleware
 )
 
 // @title			cardano-node-api

internal/api/chainsync.go

@@ -18,9 +18,8 @@ import (
 	"encoding/hex"
 	"net/http"
 
-	"github.com/blinklabs-io/cardano-node-api/internal/node"
-
 	"github.com/blinklabs-io/adder/event"
+	"github.com/blinklabs-io/cardano-node-api/internal/node"
 	ocommon "github.com/blinklabs-io/gouroboros/protocol/common"
 	"github.com/gin-gonic/gin"
 	"github.com/gorilla/websocket"

internal/api/localstatequery.go

@@ -18,10 +18,9 @@ import (
 	"encoding/hex"
 	"math"
 
+	"github.com/blinklabs-io/cardano-node-api/internal/node"
 	"github.com/blinklabs-io/gouroboros/ledger"
 	"github.com/gin-gonic/gin"
-
-	"github.com/blinklabs-io/cardano-node-api/internal/node"
 )
 
 func configureLocalStateQueryRoutes(apiGroup *gin.RouterGroup) {
@@ -229,8 +228,7 @@ func handleLocalStateQueryTip(c *gin.Context) {
 // TODO: fill this in
 //
 //nolint:unused
-type responseLocalStateQueryEraHistory struct {
-}
+type responseLocalStateQueryEraHistory struct{}
 
 // handleLocalStateQueryEraHistory godoc
 //
@@ -278,8 +276,7 @@ func handleLocalStateQueryEraHistory(c *gin.Context) {
 // TODO: fill this in
 //
 //nolint:unused
-type responseLocalStateQueryProtocolParams struct {
-}
+type responseLocalStateQueryProtocolParams struct{}
 
 // handleLocalStateQueryProtocolParams godoc
 //
@@ -327,8 +324,7 @@ func handleLocalStateQueryProtocolParams(c *gin.Context) {
 // TODO: fill this in
 //
 //nolint:unused
-type responseLocalStateQueryGenesisConfig struct {
-}
+type responseLocalStateQueryGenesisConfig struct{}
 
 // handleLocalStateQueryGenesisConfig godoc
 //

internal/api/localtxmonitor.go

@@ -18,10 +18,9 @@ import (
 	"encoding/hex"
 	"net/http"
 
+	"github.com/blinklabs-io/cardano-node-api/internal/node"
 	"github.com/blinklabs-io/gouroboros/ledger"
 	"github.com/gin-gonic/gin"
-
-	"github.com/blinklabs-io/cardano-node-api/internal/node"
 )
 
 func configureLocalTxMonitorRoutes(apiGroup *gin.RouterGroup) {

internal/api/localtxsubmission.go

@@ -19,12 +19,11 @@ import (
 	"fmt"
 	"io"
 
+	"github.com/blinklabs-io/cardano-node-api/internal/config"
+	"github.com/blinklabs-io/cardano-node-api/internal/logging"
 	"github.com/blinklabs-io/gouroboros/protocol/localtxsubmission"
 	"github.com/blinklabs-io/tx-submit-api/submit"
 	"github.com/gin-gonic/gin"
-
-	"github.com/blinklabs-io/cardano-node-api/internal/config"
-	"github.com/blinklabs-io/cardano-node-api/internal/logging"
 )
 
 func configureLocalTxSubmissionRoutes(apiGroup *gin.RouterGroup) {

internal/logging/logging.go

@@ -22,8 +22,10 @@ import (
 	"github.com/blinklabs-io/cardano-node-api/internal/config"
 )
 
-var globalLogger *slog.Logger
-var accessLogger *slog.Logger
+var (
+	globalLogger *slog.Logger
+	accessLogger *slog.Logger
+)
 
 // Configure initializes the global logger.
 func Configure() {

internal/node/chainsync.go

@@ -18,10 +18,9 @@ import (
 	"errors"
 	"time"
 
-	"github.com/blinklabs-io/cardano-node-api/internal/config"
-
 	"github.com/blinklabs-io/adder/event"
 	input_chainsync "github.com/blinklabs-io/adder/input/chainsync"
+	"github.com/blinklabs-io/cardano-node-api/internal/config"
 	"github.com/blinklabs-io/gouroboros/ledger"
 	"github.com/blinklabs-io/gouroboros/protocol/chainsync"
 	"github.com/blinklabs-io/gouroboros/protocol/common"
@@ -57,10 +56,10 @@ func buildChainSyncConfig(connCfg ConnectionConfig) chainsync.Config {
 }
 
 func chainSyncRollBackwardHandler(
-	ctx chainsync.CallbackContext,
+	_ctx chainsync.CallbackContext,
 	connCfg ConnectionConfig,
 	point common.Point,
-	tip chainsync.Tip,
+	_tip chainsync.Tip,
 ) error {
 	if connCfg.ChainSyncEventChan != nil {
 		evt := event.New(
@@ -75,11 +74,11 @@ func chainSyncRollBackwardHandler(
 }
 
 func chainSyncRollForwardHandler(
-	ctx chainsync.CallbackContext,
+	_ctx chainsync.CallbackContext,
 	connCfg ConnectionConfig,
-	blockType uint,
+	_blockType uint,
 	blockData interface{},
-	tip chainsync.Tip,
+	_tip chainsync.Tip,
 ) error {
 	cfg := config.GetConfig()
 	if connCfg.ChainSyncEventChan != nil {

internal/node/localstatequery.go

@@ -17,9 +17,8 @@ package node
 import (
 	"time"
 
-	"github.com/blinklabs-io/gouroboros/protocol/localstatequery"
-
 	"github.com/blinklabs-io/cardano-node-api/internal/config"
+	"github.com/blinklabs-io/gouroboros/protocol/localstatequery"
 )
 
 func buildLocalStateQueryConfig() localstatequery.Config {