fix: do not preallocate strings in package install (#409)

Preallocating the strings will override the container's own built in
configurations for these if they're not explicitly set in the package.
This broke the `cardano-node` package's use of arguments to the
entrypoint script.

Signed-off-by: Chris Gianelloni <[email protected]>

Author: wolf31o2

pkgmgr/package.go

@@ -731,23 +731,26 @@ func (p *PackageInstallStepDocker) install(cfg Config, pkgName string) error {
 		}
 		tmpEnv[k] = tmplVal
 	}
-	tmpCommand := []string{}
+	//nolint:prealloc
+	var tmpCommand []string
 	for _, cmd := range p.Command {
 		tmpCmd, err := cfg.Template.Render(cmd, extraVars)
 		if err != nil {
 			return err
 		}
 		tmpCommand = append(tmpCommand, tmpCmd)
 	}
-	tmpArgs := []string{}
+	//nolint:prealloc
+	var tmpArgs []string
 	for _, arg := range p.Args {
 		tmpArg, err := cfg.Template.Render(arg, extraVars)
 		if err != nil {
 			return err
 		}
 		tmpArgs = append(tmpArgs, tmpArg)
 	}
-	tmpBinds := []string{}
+	//nolint:prealloc
+	var tmpBinds []string
 	for _, bind := range p.Binds {
 		tmpBind, err := cfg.Template.Render(bind, extraVars)
 		if err != nil {
@@ -769,7 +772,8 @@ func (p *PackageInstallStepDocker) install(cfg Config, pkgName string) error {
 			)
 		}
 	}
-	tmpPorts := []string{}
+	//nolint:prealloc
+	var tmpPorts []string
 	for _, port := range p.Ports {
 		tmpPort, err := cfg.Template.Render(port, extraVars)
 		if err != nil {