fix: use %w for errors (#376)

Signed-off-by: Chris Gianelloni <[email protected]>

Author: wolf31o2

pkgmgr/config.go

@@ -39,7 +39,7 @@ func NewDefaultConfig() (Config, error) {
 	userHomeDir, err := os.UserHomeDir()
 	if err != nil {
 		return Config{}, fmt.Errorf(
-			"could not determine user home directory: %s",
+			"could not determine user home directory: %w",
 			err,
 		)
 	}
@@ -48,14 +48,14 @@ func NewDefaultConfig() (Config, error) {
 	userCacheDir, err := os.UserCacheDir()
 	if err != nil {
 		return Config{}, fmt.Errorf(
-			"could not determine user cache directory: %s",
+			"could not determine user cache directory: %w",
 			err,
 		)
 	}
 	userConfigDir, err := os.UserConfigDir()
 	if err != nil {
 		return Config{}, fmt.Errorf(
-			"could not determine user config directory: %s",
+			"could not determine user config directory: %w",
 			err,
 		)
 	}

pkgmgr/error.go

@@ -138,7 +138,7 @@ func NewNoPackageAvailableForUpgradeError(pkgSpec string) error {
 
 func NewInstallStepConditionError(condition string, err error) error {
 	return fmt.Errorf(
-		"failure evaluating install step condition %q: %s",
+		"failure evaluating install step condition %q: %w",
 		condition,
 		err,
 	)

pkgmgr/package.go

@@ -159,7 +159,7 @@ func (p Package) install(
 		}
 		if installStep.Docker != nil {
 			if err := installStep.Docker.preflight(cfg, pkgName); err != nil {
-				return "", nil, fmt.Errorf("pre-flight check failed: %s", err)
+				return "", nil, fmt.Errorf("pre-flight check failed: %w", err)
 			}
 		}
 	}
@@ -453,7 +453,7 @@ func (p Package) validate(cfg Config) error {
 	}
 	// Check version is well formed
 	if _, err := version.NewVersion(p.Version); err != nil {
-		return fmt.Errorf("package version is malformed: %s", err)
+		return fmt.Errorf("package version is malformed: %w", err)
 	}
 	// Check if package path matches package name/version
 	expectedFilePath := filepath.Join(
@@ -638,19 +638,19 @@ func (p Package) services(
 func (p Package) runHookScript(cfg Config, hookScript string) error {
 	renderedScript, err := cfg.Template.Render(hookScript, nil)
 	if err != nil {
-		return fmt.Errorf("failed to render hook script template: %s", err)
+		return fmt.Errorf("failed to render hook script template: %w", err)
 	}
 	cmd := exec.Command("/bin/sh", "-c", renderedScript)
 	cmd.Stdout = os.Stdout
 	cmd.Stderr = os.Stderr
 	// We won't be reading or writing, so throw away the PTY file
 	err = cmd.Start()
 	if err != nil {
-		return fmt.Errorf("failed to run hook script: %s", err)
+		return fmt.Errorf("failed to run hook script: %w", err)
 	}
 	err = cmd.Wait()
 	if err != nil {
-		return fmt.Errorf("run hook script exited with error: %s", err)
+		return fmt.Errorf("run hook script exited with error: %w", err)
 	}
 	return nil
 }

pkgmgr/pkgmgr.go

@@ -56,7 +56,7 @@ func NewDefaultPackageManager() (*PackageManager, error) {
 
 func (p *PackageManager) init() error {
 	if err := p.state.Load(); err != nil {
-		return fmt.Errorf("failed to load state: %s", err)
+		return fmt.Errorf("failed to load state: %w", err)
 	}
 	// Setup templating
 	p.initTemplate()