fix: preallocate structs before append (#373)

Signed-off-by: Chris Gianelloni <[email protected]>

Author: wolf31o2

pkgmgr/docker.go

@@ -1,4 +1,4 @@
-// Copyright 2024 Blink Labs Software
+// Copyright 2025 Blink Labs Software
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -161,7 +161,7 @@ func (d *DockerService) Create() error {
 		return err
 	}
 	// Convert env
-	var tmpEnv []string
+	tmpEnv := []string{}
 	for k, v := range d.Env {
 		tmpEnv = append(
 			tmpEnv,
@@ -359,7 +359,7 @@ func (d *DockerService) refresh() error {
 	}
 	d.Command = container.Config.Entrypoint[:]
 	d.Args = container.Config.Cmd[:]
-	var tmpBinds []string
+	tmpBinds := []string{}
 	for _, mount := range container.Mounts {
 		if mount.Type != "bind" {
 			continue
@@ -377,7 +377,7 @@ func (d *DockerService) refresh() error {
 		tmpBinds = append(tmpBinds, tmpBind)
 	}
 	d.Binds = tmpBinds[:]
-	var tmpPorts []string
+	tmpPorts := []string{}
 	for port, portBindings := range container.NetworkSettings.Ports {
 		// Skip exposed container ports without a mapping
 		if len(portBindings) == 0 {

pkgmgr/package.go

@@ -715,23 +715,23 @@ func (p *PackageInstallStepDocker) install(cfg Config, pkgName string) error {
 		}
 		tmpEnv[k] = tmplVal
 	}
-	var tmpCommand []string
+	tmpCommand := []string{}
 	for _, cmd := range p.Command {
 		tmpCmd, err := cfg.Template.Render(cmd, extraVars)
 		if err != nil {
 			return err
 		}
 		tmpCommand = append(tmpCommand, tmpCmd)
 	}
-	var tmpArgs []string
+	tmpArgs := []string{}
 	for _, arg := range p.Args {
 		tmpArg, err := cfg.Template.Render(arg, extraVars)
 		if err != nil {
 			return err
 		}
 		tmpArgs = append(tmpArgs, tmpArg)
 	}
-	var tmpBinds []string
+	tmpBinds := []string{}
 	for _, bind := range p.Binds {
 		tmpBind, err := cfg.Template.Render(bind, extraVars)
 		if err != nil {
@@ -753,7 +753,7 @@ func (p *PackageInstallStepDocker) install(cfg Config, pkgName string) error {
 			)
 		}
 	}
-	var tmpPorts []string
+	tmpPorts := []string{}
 	for _, port := range p.Ports {
 		tmpPort, err := cfg.Template.Render(port, extraVars)
 		if err != nil {

pkgmgr/pkgmgr.go

@@ -1,4 +1,4 @@
-// Copyright 2024 Blink Labs Software
+// Copyright 2025 Blink Labs Software
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -172,7 +172,7 @@ func (p *PackageManager) Install(pkgs ...string) error {
 	if err != nil {
 		return err
 	}
-	var installedPkgs []string
+	installedPkgs := []string{}
 	var notesOutput string
 	for _, installPkg := range installPkgs {
 		p.config.Logger.Info(
@@ -256,7 +256,7 @@ func (p *PackageManager) Upgrade(pkgs ...string) error {
 	if err != nil {
 		return err
 	}
-	var installedPkgs []string
+	installedPkgs := []string{}
 	var notesOutput string
 	for _, upgradePkg := range upgradePkgs {
 		p.config.Logger.Info(
@@ -537,7 +537,7 @@ func (p *PackageManager) uninstallPackage(
 		return err
 	}
 	// Remove package from installed packages
-	var tmpInstalledPackages []InstalledPackage
+	tmpInstalledPackages := []InstalledPackage{}
 	for _, tmpInstalledPkg := range p.state.InstalledPackages {
 		if tmpInstalledPkg.Context == uninstallPkg.Context &&
 			tmpInstalledPkg.Package.Name == uninstallPkg.Package.Name &&

pkgmgr/resolver.go

@@ -82,7 +82,7 @@ func NewResolver(
 }
 
 func (r *Resolver) Install(pkgs ...string) ([]ResolverInstallSet, error) {
-	var ret []ResolverInstallSet
+	ret := []ResolverInstallSet{}
 	for _, pkg := range pkgs {
 		pkgName, pkgVersionSpec, pkgOpts := r.splitPackage(pkg)
 		if pkg, err := r.findInstalled(pkgName, ""); err != nil {
@@ -117,7 +117,7 @@ func (r *Resolver) Install(pkgs ...string) ([]ResolverInstallSet, error) {
 }
 
 func (r *Resolver) Upgrade(pkgs ...string) ([]ResolverUpgradeSet, error) {
-	var ret []ResolverUpgradeSet
+	ret := []ResolverUpgradeSet{}
 	for _, pkg := range pkgs {
 		pkgName, pkgVersionSpec, pkgOpts := r.splitPackage(pkg)
 		installedPkg, err := r.findInstalled(pkgName, "")
@@ -202,7 +202,7 @@ func (r *Resolver) Uninstall(pkgs ...InstalledPackage) error {
 
 func (r *Resolver) getNeededDeps(pkg Package) ([]ResolverInstallSet, error) {
 	// NOTE: this function is very naive and only works for a single level of dependencies
-	var ret []ResolverInstallSet
+	ret := []ResolverInstallSet{}
 	for _, dep := range pkg.Dependencies {
 		depPkgName, depPkgVersionSpec, depPkgOpts := r.splitPackage(dep)
 		// Check if we already have an installed package that satisfies the dependency
@@ -338,7 +338,7 @@ func (r *Resolver) findAvailable(
 			extraConstraints...,
 		)
 	}
-	var ret []Package
+	ret := []Package{}
 	for _, availablePkg := range r.availablePkgs {
 		if availablePkg.Name != pkgName {
 			continue