Skip to content

Commit 3f4bcf2

Browse files
committed
ci: update golangci-lint and split go-test to separate workflow
1 parent 71668b8 commit 3f4bcf2

File tree

2 files changed

+37
-13
lines changed

2 files changed

+37
-13
lines changed

.github/workflows/go-test.yml

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
name: go-test
2+
3+
on:
4+
push:
5+
tags:
6+
- v*
7+
branches:
8+
- main
9+
pull_request:
10+
11+
jobs:
12+
go-test:
13+
name: go-test
14+
strategy:
15+
matrix:
16+
go-version: [1.20.x, 1.21.x]
17+
# XXX: is it actually useful to run unit tests on macOS?
18+
platform: [ubuntu-latest, macos-latest]
19+
runs-on: ${{ matrix.platform }}
20+
steps:
21+
- uses: actions/checkout@v3
22+
- uses: actions/setup-go@v4
23+
with:
24+
go-version: ${{ matrix.go-version }}
25+
- name: go-test
26+
run: go test ./...
Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,33 @@
11
# This file was copied from the following URL and modified:
22
# https://github.com/golangci/golangci-lint-action/blob/master/README.md#how-to-use
33

4-
name: golangci
4+
name: golangci-lint
55
on:
66
push:
77
tags:
88
- v*
99
branches:
1010
- main
1111
pull_request:
12+
1213
permissions:
1314
contents: read
1415
pull-requests: read
16+
1517
jobs:
1618
golangci:
1719
name: lint
18-
strategy:
19-
matrix:
20-
go-version: [1.20.x, 1.21.x]
21-
platform: [ubuntu-latest, macos-latest]
22-
runs-on: ${{ matrix.platform }}
20+
runs-on: ubuntu-latest
2321
steps:
24-
- uses: actions/checkout@v2
25-
- uses: actions/setup-go@v3
22+
- uses: actions/checkout@v3
23+
- uses: actions/setup-go@v4
2624
with:
27-
go-version: ${{ matrix.go-version }}
25+
go-version: 1.21.x
26+
cache: false
2827
- name: golangci-lint
2928
uses: golangci/golangci-lint-action@v3
3029
with:
31-
version: v1.53.3 # current version at time of commit
30+
version: v1.54 # current version at time of commit
3231
args: --timeout=10m
33-
only-new-issues: true
34-
- name: go-test
35-
run: go test ./...
32+
# Only show new issues in a PR but show all issues for pushes
33+
only-new-issues: ${{ github.event_name == 'pull_request' && 'true' || 'false' }}

0 commit comments

Comments
 (0)