chore: fix ID-505, added tests, and required conditions to prevent permanently locked assets

Author: nemo83

cardano/gateway/src/shared/modules/lucid/lucid.service.ts

@@ -436,23 +436,19 @@ export class LucidService {
         },
         dto.encodedMintChannelRedeemer,
       )
-      .readFrom([dto.connectionUtxo, dto.clientUtxo]);
-
-    const addPayToContract = (address: string, inline: string, token: Record<string, bigint>) => {
-      tx.pay.ToContract(address, { kind: 'inline', value: inline }, token);
-    };
-
-    addPayToContract(deploymentConfig.validators.spendHandler.address, dto.encodedUpdatedHandlerDatum, {
-      [this.getHandlerTokenUnit()]: 1n,
-    });
-    addPayToContract(deploymentConfig.validators.spendChannel.address, dto.encodedChannelDatum, {
-      [dto.channelTokenUnit]: 1n,
-    });
-    addPayToContract(
-      deploymentConfig.modules.transfer.address,
-      this.LucidImporter.Data.void(),
-      dto.transferModuleUtxo.assets,
-    );
+      .readFrom([dto.connectionUtxo, dto.clientUtxo])
+      .pay.ToContract(deploymentConfig.validators.spendHandler.address,
+        { kind: 'inline', value: dto.encodedUpdatedHandlerDatum },
+        { [this.getHandlerTokenUnit()]: 1n, }
+      )
+      .pay.ToContract(deploymentConfig.validators.spendChannel.address,
+        { kind: 'inline', value: dto.encodedChannelDatum },
+        { [dto.channelTokenUnit]: 1n, }
+      )
+      .pay.ToContract(deploymentConfig.modules.transfer.address,
+        undefined,
+        dto.transferModuleUtxo.assets
+      );
 
     return tx;
   }
@@ -551,10 +547,7 @@ export class LucidService {
       )
       .pay.ToContract(
         deploymentConfig.modules.transfer.address,
-        {
-          kind: 'inline',
-          value: this.LucidImporter.Data.void(),
-        },
+        undefined,
         dto.transferModuleUtxo.assets,
       )
       .mintAssets(
@@ -715,10 +708,7 @@ export class LucidService {
       )
       .pay.ToContract(
         deploymentConfig.modules.transfer.address,
-        {
-          kind: 'inline',
-          value: this.LucidImporter.Data.void(),
-        },
+        undefined,
         {
           ...dto.transferModuleUtxo.assets,
           lovelace: dto.transferModuleUtxo.assets.lovelace - dto.transferAmount,
@@ -808,10 +798,7 @@ export class LucidService {
       )
       .pay.ToContract(
         deploymentConfig.modules.transfer.address,
-        {
-          kind: 'inline',
-          value: this.LucidImporter.Data.void(),
-        },
+        undefined,
         {
           ...dto.transferModuleUtxo.assets,
         },
@@ -897,10 +884,7 @@ export class LucidService {
       )
       .pay.ToContract(
         deploymentConfig.modules.transfer.address,
-        {
-          kind: 'inline',
-          value: this.LucidImporter.Data.void(),
-        },
+        undefined,
         {
           ...dto.transferModuleUtxo.assets,
         },
@@ -985,10 +969,7 @@ export class LucidService {
       )
       .pay.ToContract(
         deploymentConfig.modules.transfer.address,
-        {
-          kind: 'inline',
-          value: this.LucidImporter.Data.void(),
-        },
+        undefined,
         {
           ...dto.transferModuleUtxo.assets,
           [dto.denomToken]: calculateTransferToken(
@@ -1048,10 +1029,7 @@ export class LucidService {
       )
       .pay.ToContract(
         deploymentConfig.modules.transfer.address,
-        {
-          kind: 'inline',
-          value: this.LucidImporter.Data.void(),
-        },
+        undefined,
         {
           ...dto.transferModuleUtxo.assets,
           [dto.denomToken]: calculateTransferToken(
@@ -1098,10 +1076,7 @@ export class LucidService {
       )
       .pay.ToContract(
         dto.transferModuleAddress,
-        {
-          kind: 'inline',
-          value: this.LucidImporter.Data.void(),
-        },
+        undefined,
         {
           ...dto.transferModuleUTxO.assets,
           [dto.denomToken]: calculateTransferToken(
@@ -1184,10 +1159,7 @@ export class LucidService {
       )
       .pay.ToContract(
         deploymentConfig.modules.transfer.address,
-        {
-          kind: 'inline',
-          value: this.LucidImporter.Data.void(),
-        },
+        undefined,
         {
           ...dto.transferModuleUTxO.assets,
           [dto.voucherTokenUnit]: calculateTransferToken(
@@ -1237,10 +1209,7 @@ export class LucidService {
       )
       .pay.ToContract(
         dto.transferModuleAddress,
-        {
-          kind: 'inline',
-          value: this.LucidImporter.Data.void(),
-        },
+        undefined,
         {
           ...dto.transferModuleUtxo.assets,
           lovelace: dto.transferModuleUtxo.assets.lovelace - dto.transferAmount,
@@ -1287,10 +1256,7 @@ export class LucidService {
       )
       .pay.ToContract(
         dto.transferModuleAddress,
-        {
-          kind: 'inline',
-          value: this.LucidImporter.Data.void(),
-        },
+        undefined,
         {
           ...dto.transferModuleUtxo.assets,
           [dto.denomToken]: calculateTransferToken(