fix: only extract handshake version data for NtN

agaffney · agaffney · commit 164b58484436 · 2022-11-15T19:20:50.000-06:00
Fixes #129
diff --git a/protocol/handshake/client.go b/protocol/handshake/client.go
@@ -68,10 +68,12 @@ func (c *Client) handleAcceptVersion(msgGeneric protocol.Message) error {
 	}
 	msg := msgGeneric.(*MsgAcceptVersion)
 	fullDuplex := false
-	versionData := msg.VersionData.([]interface{})
-	//nolint:gosimple
-	if versionData[1].(bool) == DIFFUSION_MODE_INITIATOR_AND_RESPONDER {
-		fullDuplex = true
+	if c.Mode() == protocol.ProtocolModeNodeToNode {
+		versionData := msg.VersionData.([]interface{})
+		//nolint:gosimple
+		if versionData[1].(bool) == DIFFUSION_MODE_INITIATOR_AND_RESPONDER {
+			fullDuplex = true
+		}
 	}
 	return c.config.FinishedFunc(msg.Version, fullDuplex)
 }

Original file line number	Diff line number	Diff line change
`@@ -68,10 +68,12 @@ func (c *Client) handleAcceptVersion(msgGeneric protocol.Message) error {`
`68`	`68`	`}`
`69`	`69`	`msg := msgGeneric.(*MsgAcceptVersion)`
`70`	`70`	`fullDuplex := false`
`71`		`- versionData := msg.VersionData.([]interface{})`
`72`		`- //nolint:gosimple`
`73`		`- if versionData[1].(bool) == DIFFUSION_MODE_INITIATOR_AND_RESPONDER {`
`74`		`- fullDuplex = true`
	`71`	`+ if c.Mode() == protocol.ProtocolModeNodeToNode {`
	`72`	`+ versionData := msg.VersionData.([]interface{})`
	`73`	`+ //nolint:gosimple`
	`74`	`+ if versionData[1].(bool) == DIFFUSION_MODE_INITIATOR_AND_RESPONDER {`
	`75`	`+ fullDuplex = true`
	`76`	`+ }`
`75`	`77`	`}`
`76`	`78`	`return c.config.FinishedFunc(msg.Version, fullDuplex)`
`77`	`79`	`}`