Merge pull request #141 from cloudstruct/feat/parse-tx-reject-reasons

feat: support for parsing TX reject reason CBOR

Author: agaffney

go.mod

@@ -3,7 +3,7 @@ module github.com/cloudstruct/go-ouroboros-network
 go 1.17
 
 require (
-	github.com/cloudstruct/go-cardano-ledger v0.1.0
+	github.com/cloudstruct/go-cardano-ledger v0.4.0
 	github.com/fxamacker/cbor/v2 v2.4.0
 )
 

go.sum

@@ -1,5 +1,5 @@
-github.com/cloudstruct/go-cardano-ledger v0.1.0 h1:HUyXl00je5aexGyrsZJ6D1gMUs0gIic8FVbQwlF6v3M=
-github.com/cloudstruct/go-cardano-ledger v0.1.0/go.mod h1:EBB9JG+3nBs3IV0p751yz1468XYkzJce1/A2X+xH8L8=
+github.com/cloudstruct/go-cardano-ledger v0.4.0 h1:4BZvwZSM82r/Bt+W4XHTstJEABg0jXcougcZgDmZBo0=
+github.com/cloudstruct/go-cardano-ledger v0.4.0/go.mod h1:EBB9JG+3nBs3IV0p751yz1468XYkzJce1/A2X+xH8L8=
 github.com/fxamacker/cbor/v2 v2.4.0 h1:ri0ArlOR+5XunOP8CRUowT0pSJOwhW098ZCUyskZD88=
 github.com/fxamacker/cbor/v2 v2.4.0/go.mod h1:TA1xS00nchWmaBnEIxPSE5oHLuJBAVvqrtAnWBwBCVo=
 github.com/x448/float16 v0.8.4 h1:qLwI1I70+NjRFUR3zs1JPUCgaCXSh3SW62uAKT1mSBM=

protocol/localtxsubmission/client.go

@@ -2,6 +2,7 @@ package localtxsubmission
 
 import (
 	"fmt"
+	"github.com/cloudstruct/go-cardano-ledger"
 	"github.com/cloudstruct/go-ouroboros-network/protocol"
 	"sync"
 )
@@ -75,7 +76,12 @@ func (c *Client) handleAcceptTx() error {
 
 func (c *Client) handleRejectTx(msg protocol.Message) error {
 	msgRejectTx := msg.(*MsgRejectTx)
-	err := TransactionRejectedError{
+	rejectErr, err := ledger.NewTxSubmitErrorFromCbor(msgRejectTx.Reason)
+	if err != nil {
+		return err
+	}
+	err = TransactionRejectedError{
+		Reason:     rejectErr,
 		ReasonCbor: []byte(msgRejectTx.Reason),
 	}
 	c.submitResultChan <- err

protocol/localtxsubmission/error.go

@@ -6,8 +6,13 @@ import (
 
 type TransactionRejectedError struct {
 	ReasonCbor []byte
+	Reason     error
 }
 
 func (e TransactionRejectedError) Error() string {
-	return fmt.Sprintf("transaction rejected: CBOR reason hex: %x", e.ReasonCbor)
+	if e.Reason != nil {
+		return e.Reason.Error()
+	} else {
+		return fmt.Sprintf("transaction rejected: CBOR reason hex: %x", e.ReasonCbor)
+	}
 }

protocol/localtxsubmission/messages.go

@@ -80,9 +80,8 @@ func NewMsgAcceptTx() *MsgAcceptTx {
 
 type MsgRejectTx struct {
 	protocol.MessageBase
-	// TODO: find a better way to handle this
-	// We use RawMessage here because the failure reason can often contain
-	// structures that we can't currently parse, such as maps with []uint8 keys
+	// We use RawMessage here because the failure reason can be numerous different
+	// structures, and we'll need to do further processing
 	Reason cbor.RawMessage
 }